-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Schema Inaccuracy] minimal-repository.license.url may be null #4310
Labels
Comments
chohner
changed the title
[Schema Inaccuracy] license.url may be null
[Schema Inaccuracy] minimal-repository.license.url may be null
Nov 22, 2024
Hello, don't be tired, my dear service, thank you for the good follow-up, I
will update
در تاریخ جمعه ۲۲ نوامبر ۲۰۲۴، ۱۷:۱۳ chris ***@***.***> نوشت:
… Schema Inaccuracy
While using ajv to validate against the provided JSON Schema, I have
found one repository where the url field of license is null - the JSON
schema however insists on string.
Expected
I expect the data to match the provided schema, so either update
minimal-repository.properties.license.properties.url to be type:
["string", "null"] or update the response to return "" on missing license
URL.
Reproduction Steps
$ curl https://api.github.com/repos/digitalservicebund/AusweisApp2Wrapper-iOS-SPM
(...)
"license": {
"key": "other",
"name": "Other",
"spdx_id": "NOASSERTION",
"url": null,
"node_id": "MDc6TGljZW5zZTA="
},
(...)
—
Reply to this email directly, view it on GitHub
<#4310>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKQVIIYF67XGR7S2KL4YMHL2B4YGVAVCNFSM6AAAAABSJMIXF2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4DGMRVHE2TAMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
👋 Hi, The API doc mention the license |
The image seems to be broken but I assume you are referring to the schema from GET /repos/{owner}/{repo}. The schema referenced there is the "license": {
"anyOf": [
{
"type": "null"
},
{
"title": "License Simple",
"description": "License Simple",
"type": "object",
"properties": {
(...)
"url": {
"type": [
"string",
"null"
],
"format": "uri",
"examples": [
"https://api.github.com/licenses/mit"
]
},
(...)
}
}
]
} The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Schema Inaccuracy
While using
ajv
to validate against the provided JSON Schema, I have found one repository where theurl
field oflicense
isnull
- the JSON schema however insists onstring
.Expected
I expect the data to match the provided schema, so either update
minimal-repository.properties.license.properties.url
to betype: ["string", "null"]
or update the response to return""
on missing license URL.Reproduction Steps
The text was updated successfully, but these errors were encountered: