Stop relying on --noincompatible_enable_cc_toolchain_resolution in Windows build
#1112
Assignees
Comments
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Dec 28, 2024
This is a follow up commit to my previous commit [1], which updated the Bazel version from 7.4.1 to 8.0.0. It turns out that --noincompatible_enable_cc_toolchain_resolution is now no-op in Bazel 8.0. Thus there remains no way other than fully migrating to the new CC toolchain resolution as planned in google#1112. Otherwise 'mozc_tip32.dll' will be built as a 64-bit executable (google#1102). This commit consists of two parts: 1. explicitly register CC toolchains in 'windows.bazelrc'. 2. Switch from '--cpu' commandline option to '--platforms' commandline option in '_win_executable_transition'. With above 'mozc_tip32.dll' will be built as a 32-bit executable again. Closes google#1102. Closes google#1112. [1]: 6dadef1
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Dec 28, 2024
This is a follow up commit to my previous commit [1], which updated the Bazel version from 7.4.1 to 8.0.0 (google#1118). It turns out that --noincompatible_enable_cc_toolchain_resolution is now no-op in Bazel 8.0. Thus there remains no way other than fully migrating to the new CC toolchain resolution as planned in google#1112. Otherwise 'mozc_tip32.dll' will be built as a 64-bit executable (google#1102). This commit consists of two parts: 1. explicitly register CC toolchains in '.bazelrc'. 2. Switch from '--cpu' commandline option to '--platforms' commandline option in '_win_executable_transition'. With above 'mozc_tip32.dll' will be built as a 32-bit executable again. Closes google#1102. Closes google#1112. [1]: 6dadef1
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Dec 28, 2024
This is a follow up commit to my previous commit [1], which updated the Bazel version from 7.4.1 to 8.0.0 (google#1118). It turns out that --noincompatible_enable_cc_toolchain_resolution is now no-op in Bazel 8.0. Thus there remains no way other than fully migrating to the new CC toolchain resolution as planned in google#1112. Otherwise 'mozc_tip32.dll' will be built as a 64-bit executable (google#1102). This commit consists of two parts: 1. explicitly register CC toolchains in '.bazelrc'. 2. Switch from '--cpu' commandline option to '--platforms' commandline option in '_win_executable_transition'. With above 'mozc_tip32.dll' will be built as a 32-bit executable again. Closes google#1102. Closes google#1112. [1]: 6dadef1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Follows up to the following issue.
mozc_tip32.dllbuild with Bazel is not 32-bit binary #1102.bazelrc" #1103As a long term solution, we should complete the migration to platforms in Windows build.
This is not a release blocker of our migration from GYP to Bazel though.
Steps to reproduce
Steps to reproduce the behavior:
Mozc64.msiwithout specifying--noincompatible_enable_cc_toolchain_resolutionExpected behavior
There is no regression.
Actual behavior
Currently
mozc_tip32.dllcannot be built as a 32-bit binary.mozc_tip32.dllbuild with Bazel is not 32-bit binary #1102Version or commit-id
e1b40ed
Environment
The text was updated successfully, but these errors were encountered: