Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“Is” directive with mutually-exclusive arguments is smelly #52

Open
gmac opened this issue Sep 25, 2024 · 2 comments
Open

“Is” directive with mutually-exclusive arguments is smelly #52

gmac opened this issue Sep 25, 2024 · 2 comments

Comments

@gmac
Copy link

gmac commented Sep 25, 2024 •
edited
Loading

From https://github.com/graphql/composite-schemas-spec/blob/main/spec/Section%202%20--%20Source%20Schema.md#is.

If the arguments of “is” are mutually exclusive and fail composition in tandem, then why are they a single directive? Making them separate directives would make this impossible and push developers into the pit of success.
@benjie
Copy link
Member

benjie commented Sep 25, 2024

Alternatively; use @oneOf?

@glen-84
Copy link
Contributor

glen-84 commented Sep 27, 2024

It's a single FieldSelectionMap argument in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjie @glen-84 @gmac