Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Optional expo mobile app & packages #259

Open
oldbettie opened this issue Nov 17, 2024 · 3 comments
Open

Feature Request: Optional expo mobile app & packages #259

oldbettie opened this issue Nov 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@oldbettie
Copy link

oldbettie commented Nov 17, 2024

Describe the solution you'd like
Would be nice to add an optional package for an expo/react-native application.
This would even be a nohoist package that is handled separately but can use the other packages for less code duplication.

Edit:
turns out this is not overly complex to add.

  • from the root dir run: pnpm create expo apps/mobile
  • in turbo.json under build/outputs add , "node_modules/.cache/metro/**"
  • in launch.json add
    {
      "name": "Expo: debug client-side (app)",
      "type": "chrome",
      "request": "launch",
      "url": "http://localhost:3006"
    },
  • in the new apps package.json add "dev": "expo start -p 3006" under scripts

This was enough to get expo running in the same pnpm dev command with everything else. I still need to test it more extensively

Edit 2.0
This breaks completely once you run pnpm i from the root of the repo. It hoists dependencies and I cant seem to get beyond this point or revert the change

@oldbettie oldbettie added the enhancement New feature or request label Nov 17, 2024
@oldbettie oldbettie changed the title Optional Expo mobile app & packages Feature Request: Optional expo mobile app & packages Nov 17, 2024
@Balance8
Copy link
Contributor

+1 to add this

@adelrodriguez
Copy link

@oldbettie try setting node-linker=hoisted in a .npmrc file (recommended by Expo docs). I've had similar issues with getting an Expo app working inside a pnpm monorepo and this did the trick.

@oldbettie
Copy link
Author

actually I did try that. Along with a few other things. I might have another shot this weekend at setting this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants