Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Last character leaves a trail when scrolling the list with .Xresource based terminal #4144

Open
7 of 10 tasks
fsc0 opened this issue Dec 26, 2024 · 3 comments
Open
7 of 10 tasks

Comments

@fsc0
Copy link

fsc0 commented Dec 26, 2024

Checklist

  • I have read through the manual page (man fzf)
  • I have searched through the existing issues
  • For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version

0.57.0

OS

  • Linux
  • macOS
  • Windows
  • Etc.

Shell

  • bash
  • zsh
  • fish

Problem / Steps to reproduce

This bug is reproducible with st, xterm, rxvt-unicode,
But not with kitty, alacritty.

Did test with default .Xresource setting.

Tested on Void Linux 6.12.6_3.

img

@fsc0
Copy link
Author

fsc0 commented Dec 26, 2024

dummy-UTF-8.txt

I did further research and realized the encoding of that dummy.txt on gif demo was UTF-8,
And bug couldn't reproduce with ASCII.

img

EDIT: Upload dummy-UTF-8.txt

@fsc0 fsc0 changed the title [Bug] Last character of longest line leaves a trail when scrolling the list with .Xresource based terminal [Bug] Last character leaves a trail when scrolling the list with .Xresource based terminal Dec 26, 2024
@fsc0
Copy link
Author

fsc0 commented Dec 26, 2024

hny.txt

If the last character of the line is CJK character, bug can't reproduce.
And the trail leaving the mark all over previous lines passed.

img

Related: #1526, #2020
Issue #2194, conditions are quiet different but quite similar.

EDIT: Further info

@fsc0
Copy link
Author

fsc0 commented Dec 27, 2024

Thanks for the info @y0ast
#1526 (comment)

t.window.CPrint(color, strings.Repeat(" ", fillSpaces))

t.window.CPrint(color, strings.Repeat(" ", 2 * fillSpaces)) 

t.window.Print(strings.Repeat(" ", fillSpaces))

t.window.Print(strings.Repeat(" ", 2 * fillSpaces))

But scrollbar not displaying properly, and layout broken with some options like header.

@fsc0 fsc0 closed this as completed Dec 27, 2024
@fsc0 fsc0 reopened this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant