Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'navigate files and folders with single click' only effective in jupyter lab #7538

Open
zjqzero opened this issue Dec 11, 2024 · 4 comments
Open
Labels
bug status:Needs Info status:Needs Triage Applied to issues that need triage
Milestone

Comments

@zjqzero
Copy link

zjqzero commented Dec 11, 2024

Description

upgrade to 7.3.1,'navigate files and folders with single click' not checked, but it's still affecting the behavior.

This option only effective in jupyter lab.

Image

@zjqzero zjqzero added bug status:Needs Triage Applied to issues that need triage labels Dec 11, 2024
@andrii-i
Copy link
Contributor

andrii-i commented Dec 17, 2024

Hi @zjqzero. Thank you for creating this issue. I have tested this locally and I can't reproduce this with notebook 7.3.1 on M1 MacBook Pro macos 15.1.1 ('navigate files and folders with single click' is respected).

Could you please provide more information about the system and notebook version you are using?

- Operating System and version: <!-- e.g. Linux Ubuntu 21.04 -->
- Browser and version: <!-- e.g. Chrome 92 -->
<!-- Please note the Notebook version you are working with. You can find this in the Help -> About Jupyter Notebook menu option or by running `jupyter --version` from your terminal -->
- Jupyter Notebook version: <!-- e.g. 3.1.7 -->

@pythonic2020
Copy link

pythonic2020 commented Dec 25, 2024

Using notebook 7.3.2 in a conda env on Win64 running Python 3.9, using only default notebook settings, I am getting the single-click behavior even though "Navigate files and directories with single click" setting is unchecked. This erroneous behavior is exactly that described by @zjqzero. There is also other bad behavior after closing a Firefox tab that contained an opened .ipynb file where the mouse cursor changes to a crossed-out circle with the filename of the .ipynb file just closed (see screenshot below). This bad cursor behavior disappears after clicking on notebook background.

Image

If the "Navigate files and directories with single click" setting is checked and then unchecked, the behavior returns to normal.

This looks like a serious bug to me, but is probably not hard to fix.

@jtpio
Copy link
Member

jtpio commented Dec 26, 2024

Thanks all for the report.

If the "Navigate files and directories with single click" setting is checked and then unchecked, the behavior returns to normal.

This can likely be the workaround for now.

Otherwise the issue mentioned above with files being dragged does seem to be easily reproducible indeed.

@jtpio jtpio added this to the 7.3.x milestone Dec 26, 2024
@jtpio
Copy link
Member

jtpio commented Dec 26, 2024

The tricky part here is both JupyterLab and Jupyter Notebook use the same settings for the file browser widget, but not the same set of defaults.

Which explains why the checkbox is unchecked but the single click navigation enabled in Jupyter Notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status:Needs Info status:Needs Triage Applied to issues that need triage
Projects
None yet
Development

No branches or pull requests

4 participants