Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for kube-vip workaround introduced for v1.29 #2596

Open
chrischdi opened this issue Jan 8, 2024 · 9 comments
Open

Tracking issue for kube-vip workaround introduced for v1.29 #2596

chrischdi opened this issue Jan 8, 2024 · 9 comments
Labels
area/govmomi Issues or PRs related to the govmomi mode lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@chrischdi
Copy link
Member

This issue is for tracking the following two kube-vip issues:

We did hit this issue while implementing support for v1.29 for #2564 in:

As a follow-up we removed a part of the above PR because it caused flakes in e2e tests in:
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2024
@sbueringer
Copy link
Member

/remove-lifecycle stale

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 8, 2024
@sbueringer sbueringer added the area/govmomi Issues or PRs related to the govmomi mode label Apr 18, 2024
@chrischdi
Copy link
Member Author

We should try to get rid of packaging/flavorgen/flavors/kubevip/kube-vip-prepare.sh for k8s >= v1.31, because CAPI enables the ControlPlaneKubeletLocalMode feature-gate in kubeadm and that should make us not depend on the super-admin.conf anymore.

More information: kube-vip/kube-vip#684 (comment)

@neolit123
Copy link
Member

because CAPI enables the ControlPlaneKubeletLocalMode feature-gate in kubeadm and that should make us not depend on the super-admin.conf anymore.

More information: kube-vip/kube-vip#684 (comment)

cc @christianang @lubronzhan

@lubronzhan
Copy link
Contributor

Good. I can work on this

@sbueringer
Copy link
Member

sbueringer commented Aug 23, 2024 •
edited
Loading

Great! We were thinking about having an if/else (or enabledIf) based on Kubernetes version to stop adding these workaround patches for >= 1.31

@sbueringer
Copy link
Member

@chrischdi could this (kubernetes/kubernetes#126460) somehow fix the first issue?

@chrischdi
Copy link
Member Author

Not really sure, but may be worth a try.

@lubronzhan lubronzhan mentioned this issue Aug 23, 2024
Closed
@sbueringer
Copy link
Member

Context: kubernetes/kubernetes#126460 was done because of this bug report related to kube-vip kubernetes/kubernetes#119852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/govmomi Issues or PRs related to the govmomi mode lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@neolit123 @chrischdi @sbueringer @lubronzhan @k8s-ci-robot @k8s-triage-robot