🌱 [WIP] test: stream logs for CPI and CSI to artifacts #2615
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2615 +/- ##
==========================================
+ Coverage 64.46% 64.74% +0.27%
==========================================
Files 118 118
Lines 8580 8580
==========================================
+ Hits 5531 5555 +24
+ Misses 2612 2595 -17
+ Partials 437 430 -7 ☔ View full report in Codecov by Sentry. |
chrischdi
force-pushed
the
pr-watch-vsphere-csi-cpi-logs
branch
from
ad12f6a to
89dc2ed
Compare
k8s-ci-robot
added
size/L
| @@ -105,6 +105,9 @@ func VerifyAntiAffinity(ctx context.Context, input AntiAffinitySpecInput) { | |||
| WaitForClusterIntervals: input.Global.E2EConfig.GetIntervals("", "wait-cluster"), | |||
| WaitForControlPlaneIntervals: input.Global.E2EConfig.GetIntervals("", "wait-control-plane"), | |||
| WaitForMachineDeployments: input.Global.E2EConfig.GetIntervals("", "wait-worker-nodes"), | |||
| PostMachinesProvisioned: func() { | |||
There was a problem hiding this comment.
Should this be PostClusterInitialized?
(with some tolerance to give time to CRS to be applied, assuming we are using CRS to deploy the CSI/CPI)
There was a problem hiding this comment.
I was not able to find a PostClusterInitialized 🤔
There was a problem hiding this comment.
Note: have to rethink this, PostMachinesProvisioned won't be very helpful because this is more on a happy path then. Machines may not even get provisioned and we want the logs.
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chrischdi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@chrischdi What is the current state of this PR? (fine to close if we currently don't have the right time / bandwidth ratio :)) |
|
Let's close, the thought I had did also not make sense, we can't use /close |
|
@chrischdi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2614