Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect unexpected errors via logs in envtest and e2e tests #11402

Open
sbueringer opened this issue Nov 11, 2024 · 5 comments
Open

Detect unexpected errors via logs in envtest and e2e tests #11402

sbueringer opened this issue Nov 11, 2024 · 5 comments
Labels
area/testing Issues or PRs related to testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

sbueringer commented Nov 11, 2024

It would be great if we find a way to surface unexpected conditions via logs and then check in envtest and e2e tests that they never occur.

Of course this requires us to have an easy way to identify such logs (e.g. they could contain a specific keyword).

Recently we implemented something similar for panics. After envtest and e2e tests are completed we check controller-runtime metrics to ensure no panics occured

@sbueringer sbueringer added the area/testing Issues or PRs related to testing label Nov 11, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 11, 2024
@sbueringer sbueringer changed the title Detected unexpected logs in envtest and e2e tests Detect unexpected logs in envtest and e2e tests Nov 11, 2024
@sbueringer sbueringer changed the title Detect unexpected logs in envtest and e2e tests Detect unexpected errors via logs in envtest and e2e tests Nov 11, 2024
@sbueringer sbueringer added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Nov 13, 2024
@k8s-ci-robot k8s-ci-robot removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels Nov 13, 2024
@sbueringer
Copy link
Member Author

/triage accepted

But next step is

Of course this requires us to have an easy way to identify such logs (e.g. they could contain a specific keyword).

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 13, 2024
@sbueringer
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 13, 2024
@faermanj
Copy link

faermanj commented Dec 4, 2024

@sbueringer I'm interested in helping with this one. Do we want to catch known patterns (rules based) or anything out of the ordinary (ML-based)?

@sbueringer
Copy link
Member Author

sbueringer commented Dec 27, 2024

Nothing fancy, ideally just looking for a substring. We have to figure out this one first though:

Of course this requires us to have an easy way to identify such logs (e.g. they could contain a specific keyword).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants