Kustomize/helmCharts: omitting helmChart.repo value does not fallback cleanly to local chartHome

[DClabaut]

What happened?

This documentation page specifies a way to load a local Chart by omitting helmCharts.repo value and specifying helmGlobals.chartHome instead.

This method does not work, as chartHome does not appear to be taken into account at all:

What did you expect to happen?

Helm chart should be loaded from mycharts/

How can we reproduce it (as minimally and precisely as possible)?

Get the chart by using the valid remote repo:

$ tree -L 3
.
└── kustomization.yaml

0 directories, 1 file

# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

helmGlobals:
  chartHome: mycharts

helmCharts:
  - name: harbor
    repo: https://helm.goharbor.io
    releaseName: harbor
    version: 1.16.0

$ kustomize build --enable-helm . > /dev/null
$ tree -L 3
.
├── kustomization.yaml
└── mycharts
    └── harbor-1.16.0
        ├── harbor
        └── harbor-1.16.0.tgz

Try to load the chart from the local custom repo by commenting helmCharts.repo:

# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

helmGlobals:
  chartHome: mycharts

helmCharts:
  - name: harbor
    #repo: https://helm.goharbor.io
    releaseName: harbor
    version: 1.16.0

$ kustomize build --enable-helm . > /dev/null
Error: no repo specified for pull, no chart found at ''

Dirty workaround: set different value for helmGlobals.chartHome, specifying one folder down:

# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

helmGlobals:
  chartHome: mycharts/harbor-1.16.0

helmCharts:
  - name: harbor
    #repo: https://helm.goharbor.io
    releaseName: harbor
    version: 1.16.0

Command now runs:

$ kustomize build --enable-helm . > /dev/null
$ echo $?
0

Expected output

Rendered Helm chart

Actual output

Error: no repo specified for pull, no chart found at ''

Kustomize version

5.5.0

Operating system

Linux

[k8s-ci-robot]

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[DClabaut]

Closing issue, the empty harbor-1.16.0.tgz folder had not been copied

[DClabaut]

Reopening with more details - can reproduce consistently now

[aarnaud]

Introduce by a0f131c
#4999

func (p *plugin) absChartHome() string {
	var chartHome string
	if filepath.IsAbs(p.ChartHome) {
		chartHome = p.ChartHome
	} else {
		chartHome = filepath.Join(p.h.Loader().Root(), p.ChartHome)
	}

	if p.Version != "" && p.Repo != "" {
		return filepath.Join(chartHome, fmt.Sprintf("%s-%s", p.Name, p.Version))
	}
	return chartHome
}

should be

func (p *plugin) absChartHome() string {
	var chartHome string
	if filepath.IsAbs(p.ChartHome) {
		chartHome = p.ChartHome
	} else {
		chartHome = filepath.Join(p.h.Loader().Root(), p.ChartHome)
	}

	if p.Version != ""  {
		return filepath.Join(chartHome, fmt.Sprintf("%s-%s", p.Name, p.Version))
	}
	return chartHome
}