Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection-limits: whitelist PeerId or Multiaddr to bypass checks. #5605

Open
dariusc93 opened this issue Sep 19, 2024 · 2 comments · May be fixed by #5720
Open

connection-limits: whitelist PeerId or Multiaddr to bypass checks. #5605

dariusc93 opened this issue Sep 19, 2024 · 2 comments · May be fixed by #5720

Comments

@dariusc93
Copy link
Member

dariusc93 commented Sep 19, 2024 •
edited
Loading

Description

Ability to grant a peer to bypass connection limit, either by their peerid or multiaddr, allowing the connection to be established to the node when the connection limits are at its max.

Motivation

A node, which is already at its max in terms of connections, may wish to allow specific peers to connect without wanting to drop existing connections to allow the peer through.

Are you planning to do it yourself in a pull request ?

Maybe
@drHuangMHT
Copy link
Contributor

Does that mean without connection-limit behaviour the swarm will keep accepting connections until crashing?

@dariusc93
Copy link
Member Author

Does that mean without connection-limit behaviour the swarm will keep accepting connections until crashing?

Possible, but unless the connection is rejected due to the host running out of resources (eg it reaching a limit on file descriptors, host is busy or does not respond in time, etc).

@drHuangMHT drHuangMHT linked a pull request Dec 6, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(connection-limit): set bypass rules for connections drHuangMHT/rust-libp2p
2 participants
@dariusc93 @drHuangMHT