Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Untranslated string appear on dialog for "You have changed the data deletion settings. Please save them before starting a purge." #22901

Open
4 tasks done
mikkeschiren opened this issue Dec 27, 2024 · 1 comment · May be fixed by #22902
Assignees
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member
Milestone

Comments

@mikkeschiren
Copy link
Contributor

What happened?

In privacy settings, and you change the value of "Regularly delete old raw data" and do not save it, and then click the Purge DB Now link at "Schedule old data deletion", you get an dialog with an untranslated confirm button ({{ TRANSLATE('GENERAL_OK') }}).

What should happen?

The Ok button should have translated text.

How can this be reproduced?

Go to privacy settings in th admin area, change the Regularly delete old raw data to a new value without saving. Click Purge DB Now.

Matomo version

5.2.1

PHP version

8.2.26

Server operating system

No response

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

No response

Validations

@mikkeschiren mikkeschiren added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Dec 27, 2024
@mikkeschiren
Copy link
Contributor Author

image

sgiehl added a commit that referenced this issue Dec 29, 2024
@sgiehl sgiehl linked a pull request Dec 29, 2024 that will close this issue
11 tasks
@sgiehl sgiehl self-assigned this Dec 29, 2024
@sgiehl sgiehl added this to the 5.3.0 milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants