Add support for macOS (Darwin) for Java and Rust #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @tonyfettes, Thank you very much for your contribution! Kindly fill the CLA, which is a requirement for accepting the contribution, and I am very glad to merge the PR. |
|
Dear @tonyfettes , Thanks a lot for making the PR. In order for me to merge the PR, I request you to kindly fill the CLA as per the instructions shared by microsoft-github-policy-service bot. Kindly let me know if there's anything I can help address regarding the same, and thank you very much for your contribution! |
|
@microsoft-github-policy-service agree |
DaniHi
approved these changes
Mar 11, 2024
|
@LakshyAAAgrawal could you merge? |
|
Dear @tonyfettes, Thanks a lot for the PR. @AetherPrior, I will be reviewing it in a few days and will merge it soon after. Please allow me some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes microsoft/multilspy#28 , i.e. add support Java and Rust LSPs on macOS.