Dear @DanCip00 ,

Thanks a lot for your PR! Have you been able to get pyright working with this change?

Hi, I was trying to use your code to request completion in Python using Pyright and I ran into the same problem #10. Now it works fine for me. But now that I think about it maybe it's better to wrap the line around an if statement like this:

if self.language_id is not Language.PYTHON:
    await self.completions_available.wait()

I would actually recommend creating a separate class for pyright, copying the full code for jedi, while modifying the following three lines: https://github.com/microsoft/multilspy/blob/main/src/multilspy/language_servers/jedi_language_server/jedi_server.py#L82C1-L84C49

These lines in the jedi client wait for jedi to report completions available, and sets the corresponding flag. Since it appears that this is not needed in pyright, you can directly make a call to this in start_server, before yielding.

Could you please make that change?

BTW, thanks a lot for this PR. I wasn't aware that this was the issue blocking pyright to work with multilspy. Thanks a lot for debugging this!

Please feel free to let me know iif I can help with anything on the PR.

I am encountering the same issue of infinite waiting even when using jedi-language-server concerning the use of request_completions. I would like to ask you to verify if it works correctly for you :)

I am not an expert on the matter, but my hypothesis is that this call has not been implemented in the python-lsp-server library, on which the others are based. Is this possible?

@DanCip00 can you please accept the CLA?

@microsoft-github-policy-service agree