Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactNativeIsland should be accessible from the ReactNativeWin32App #14173

Open
acoates-ms opened this issue Dec 6, 2024 · 1 comment
Open
Assignees
Milestone

Comments

@acoates-ms
Copy link
Contributor

acoates-ms commented Dec 6, 2024

There are use cases where Apps may need access to the ReactNativeIsland object.

See the issue originally posted by @austinhallock in #14136 (comment)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 6, 2024
@chrisglein chrisglein added enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 9, 2024
@chrisglein chrisglein added this to the 0.77 milestone Dec 9, 2024
@chrisglein
Copy link
Member

chrisglein commented Dec 9, 2024

Great to get feedback on the builder. Goal is that people can scale up to their needs from the basic things. This was something we missed exposing. Should be clear to add, let's try for 0.77. Just need a getter, not to provide custom island.

Design note: add to React Native Win32 app, not the builder. That's not the builder's job.
Needs to be accessible in the right timing window. It's creating in start, which is the loop and doesn't return. So there's some timing work to be thought through.

@chrisglein chrisglein changed the title ReactNativeIsland should be accessible from the ReactNativeAppBuilder ReactNativeIsland should be accessible from the ReactNativeWin32App Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants