Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfork ComponentDescriptorRegistry.cpp #14204

Open
TatianaKapos opened this issue Dec 13, 2024 · 1 comment
Open

Unfork ComponentDescriptorRegistry.cpp #14204

TatianaKapos opened this issue Dec 13, 2024 · 1 comment
Labels
Deforking Integration Follow-up Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
Milestone

Comments

@TatianaKapos
Copy link
Contributor

TatianaKapos commented Dec 13, 2024

Problem Description

Broke pages for Glyph UWP, Fabric Native Component, and Fabric Native Component Yoga. It looks like the removed the fallback if there's no component descriptor. Need to figure out if we want to make an upstream change to add these back in or change our implementation.

Image

Link to the integration where the error originated

#14167

Link to commit

https://github.com/facebook/react-native/pull/47321/files#diff-72b7ba7c6e256aefc85b580139f3023d60892ad5a74beb17754e4c786716cb6c

Forked files

  1. ComponentDescriptorRegistry.cpp

Upstream PR

No response

Build Configuration

None

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 13, 2024
@TatianaKapos TatianaKapos changed the title Unfork ComenentDescriptorRegistry.cpp Unfork ComponentDescriptorRegistry.cpp Dec 13, 2024
@chrisglein
Copy link
Member

Code has been forked to keep the component descriptor fallback. Question is whether we still need this moving forward on new architecture and are just keeping this around for Paper or not. I'm not so worried about Glyph, curious about the risk. @acoates-ms What's you're thought on how this should work moving forward?

@chrisglein chrisglein added Deforking and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 19, 2024
@chrisglein chrisglein added this to the Backlog milestone Dec 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deforking Integration Follow-up Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
Projects
None yet
Development

No branches or pull requests

2 participants