Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfork/Implement ImageRequest function #14216

Open
TatianaKapos opened this issue Dec 19, 2024 · 1 comment
Open

Unfork/Implement ImageRequest function #14216

TatianaKapos opened this issue Dec 19, 2024 · 1 comment
Labels
Area: Image enhancement Integration Follow-up Parity: React Native RNW does not look or behave like upstream RN platforms
Milestone
Backlog

Comments

@TatianaKapos
Copy link
Contributor

TatianaKapos commented Dec 19, 2024 •
edited
Loading

Problem Description

Upstream implemented a new ImageManager::requestImage function (currently added as a stub method in our ImageManager.cpp) that we should be tracking to implement.

It also introduced a file called ImageRequestParams.h which we will need to create aswell (currently just brought in their implementation as an override to fix import statements)

Link to the integration where the error originated

#14214

Link to commit

facebook/react-native#47723

  1. vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/imagemanager/ImageRequestParams.h

No response

Upstream PR

N/A

Build Configuration

None
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 19, 2024
@TatianaKapos TatianaKapos mentioned this issue Dec 19, 2024
Merged
@chrisglein
Copy link
Member

Matched what was already there and created a forked file for Windows, unclear if we need our own implementation.

@chrisglein chrisglein added enhancement Area: Image and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 19, 2024
@chrisglein chrisglein added this to the Backlog milestone Dec 19, 2024
@chrisglein chrisglein added the Parity: React Native RNW does not look or behave like upstream RN platforms label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Image enhancement Integration Follow-up Parity: React Native RNW does not look or behave like upstream RN platforms
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@chrisglein @TatianaKapos