Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Crashes with ReactCSSTransitionGroup #20

Open
at0g opened this issue Jul 30, 2015 · 0 comments
Open

Crashes with ReactCSSTransitionGroup #20

at0g opened this issue Jul 30, 2015 · 0 comments

Comments

@at0g
Copy link

at0g commented Jul 30, 2015

I'm experiencing a weird issue when using using this lib with ReactCSSTransitionGroup.

I have a transition that is working fine in conjunction with react-router (simply fading page transitions).

However when using the transition group for a carousel, the app crashes (unpredictably and intermittently when changing slides).

If I remove winstore-jscompat and continue to use the transition group, the app crashes with the dangerous dom insertion issue.

So far, the only workaround I've found is to render all of the carousel items to the DOM, and then apply an active class modifier - this is not good for performance.

It seems to me the thinking with adding these security rules in metro was not great - they cause problems with the frameworks people actually use to create app like experiences. Thanks for your efforts with this library to try and address them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant