Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The automatic_branch_deletion ruletype doesn't work properly #66

Open
rdimitrov opened this issue Mar 20, 2024 · 1 comment
Open

The automatic_branch_deletion ruletype doesn't work properly #66

rdimitrov opened this issue Mar 20, 2024 · 1 comment
Labels
P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@rdimitrov
Copy link
Member

The automatic_branch_deletion fails to work properly.

Minder relies on webhook events to know the state of a certain setting, like this one. Unfortunately for this particular setting GitHub doesn't provide webhook events when it is changed, so Minder has no way to know whether something was fixed or not after its initial evaluation.

The reason this is not entirely broken is that Minder can update the profile status in the following use cases:

  • When the repo is registered and/or when the profile is created.
  • If Minder receives another webhook event that triggers the re-evaluation for this ruletype.
@evankanderson evankanderson added the P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage label Jul 16, 2024
@mesembria
Copy link
Contributor

Will be addressed with reminder work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
None yet
Development

No branches or pull requests

3 participants