Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMC Key Mapping - SA Updates - Configurations - Unit Tests #256

Open
rjbrown2 opened this issue Jun 28, 2024 · 1 comment
Open

KMC Key Mapping - SA Updates - Configurations - Unit Tests #256

rjbrown2 opened this issue Jun 28, 2024 · 1 comment
Assignees

Comments

@rjbrown2
Copy link
Member

#198
#255

Continue update on KMC Interface side.
Should just require a new query to return all of the associations by SPI, ekid, and akid. The same logic (plus sql code) should be all that is needed.

Will require automated containers for testing.

This should be handled at the same time as an SA and unit test rework, as this update will break all tests, and require the SA work to be fully implemented - As per #171, we should have an SA for each algorithm and combination of encryption methods. These new SA descriptions should also have unique keys associated with them per the standard (currently 130 is used for all).

Following SA updates, Unit tests can be reconfigured with more coverage, and made more generic and used with every module. This will require some unit test config genericism, and we should also consider updating some interfaces, and adding others as mentioned by Cutright:

Reviewing this and had a thought looking over lines like the following:

extern int32_t Crypto_Config_CryptoLib(uint8_t key_type, uint8_t sadb_type, uint8_t cryptography_type, uint8_t crypto_create_fecf, uint8_t process_sdls_pdus, uint8_t has_pus_hdr, uint8_t ignore_sa_state, uint8_t ignore_anti_replay, uint8_t unique_sa_per_mapid, uint8_t crypto_check_fecf, uint8_t vcid_bitmask, uint8_t crypto_increment_nontransmitted_iv);

Should we split this config into two configuration functions? One for configuring interfaces, and one for configuring behavior?

e.g. : Crypto_Config_Interfaces(key_type, sadb_type, cryptography_type)
Crypto_Config_Behavior(crypto_create_fecf, process_sdls_pdus, has_pus_hdr, ignore_sa_state, ignore_anti_replay, unique_sa_per_mapid, crypto_check_fecf, vcid_bitmask, crypto_increment_nontransmitted_iv);

#171
#149
#185

@rjbrown2 rjbrown2 self-assigned this Jun 28, 2024
rjbrown2 pushed a commit that referenced this issue Jul 29, 2024
…d recurison to array insertion. Updated unit tests
rjbrown2 pushed a commit that referenced this issue Aug 16, 2024
jlucas9 added a commit that referenced this issue Aug 19, 2024
Cryptolib#256 - SA Update, Managed Parameters, UTs
@jlucas9
Copy link
Collaborator

jlucas9 commented Aug 19, 2024

Merged into dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants