Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flagd] add reconnect e2e tests #411

Open
toddbaert opened this issue Dec 22, 2023 · 8 comments
Open

[flagd] add reconnect e2e tests #411

toddbaert opened this issue Dec 22, 2023 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Dec 22, 2023

Implement the "reconnect e2e test suite" here by adding it to the existing e2e test suite.

How to:

  • start ghcr.io/open-feature/flagd-testbed-unstable and ghcr.io/open-feature/sync-testbed-unstable containers (these restart every 5s)
  • run the gherkin suite about twice (once for in-process and once for the RPC provider)

See the Java implementation PR here.

@toddbaert toddbaert added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 22, 2023
@NeerajGartia21
Copy link

@toddbaert I think you have missed the link to the Java implementation PR. Can you please update it?

@toddbaert
Copy link
Member Author

@toddbaert I think you have missed the link to the Java implementation PR. Can you please update it?

Updated! Thanks!

@NeerajGartia21
Copy link

@toddbaert please update the link to the flagd-testbed to add flagd-reconnect.feature in the repo.

@toddbaert
Copy link
Member Author

@toddbaert please update the link to the flagd-testbed to add flagd-reconnect.feature in the repo.

I'm sorry, I don't understand your request.

Do you mean update the git submodule? If so, you should be able to do that in a branch.

@NeerajGartia21
Copy link

NeerajGartia21 commented Feb 6, 2024

Yeah, I mean the git submodule.
I'll update that in the PR.

@toddbaert
Copy link
Member Author

toddbaert commented Feb 6, 2024

Sure, just cd into the submodule and do a checkout (disregard if it gives you "detatched head" errors). If you have trouble, let me know and I can do it and then you can rebase on it.

@NeerajGartia21
Copy link

@toddbaert I tried adding reconnect e2e tests but I'm having a trouble debugging the issue with the PROVIDER_ERROR callback. The ProviderErrorCallback is not being called when connection breaks. Here is my implementation if you have time please have a look into it.

@Kavindu-Dodan
Copy link
Contributor

@NeerajGartia21 sorry for the delay on checking back on this.

I checked your code and I think root cause is not defining providerErrorCallback function as a global function. Can you attempt that and see if this get resolved ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants