You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@OgDev-01 Sorry for being inactive the past few days. I checked the code and noticed syncID isn’t being used. Should we remove it or comment it out for now?
@Himanshu-Kathania Liked your approach, it works well but needs the uuid dependency. Let me know!
Also, please check PR and let me know the next steps or any updates.
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass. Most often, our PR titles are something like one of these:
docs: correct typo in README
feat: implement dark mode"
fix: correct remove button behavior
Linting Errors
Found type "Bug", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
@vaibhav-xp to clear this error, you can just change your PR title from Bug: Charts hover states are not standalone #4189 to fix: Charts hover states not being standalone
vaibhav-xp
changed the title
Bug: Charts hover states are not standalone #4189
fix: Charts hover states are not standalone #4189
Nov 20, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vaibhav-xp
requested review from
brandonroberts,
zeucapua and
nickytonline
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Description
@OgDev-01 Sorry for being inactive the past few days. I checked the code and noticed syncID isn’t being used. Should we remove it or comment it out for now?
@Himanshu-Kathania Liked your approach, it works well but needs the uuid dependency. Let me know!
Also, please check PR and let me know the next steps or any updates.
Related Tickets & Documents
issue numbers: Fixes #4189
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2024-11-20.092803.mp4
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?