Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with_span doesn't call record_exception #236

Open
garthk opened this issue Mar 26, 2021 · 2 comments · May be fixed by #622
Open

with_span doesn't call record_exception #236

garthk opened this issue Mar 26, 2021 · 2 comments · May be fixed by #622

Comments

@garthk
Copy link
Contributor

garthk commented Mar 26, 2021

I'd expect with_span to catch errors/exceptions, call record_exception, set the span status, and then re-raise like it did in OpenCensus.Elixir. I can't see it happening, though, nor find any mechanism for it.

In the OT world, adding events for exceptions is the default for Python, though they also provide record_exception and set_status_on_exception as start options on their start_span so users can opt out. (Note it returns a context manager, so Python's with start_span(…): is equivalent to our with_span.)

@garthk
Copy link
Contributor Author

garthk commented Mar 26, 2021

Only just noticed: record_exception is Elixir-side-only.

@garthk
Copy link
Contributor Author

garthk commented Mar 27, 2021

Experiment adding OT Python style opt-out record_exception and set_status_on_exception start options on with_span/4: https://gist.github.com/garthk/fddffdb2880b665c296cab435f216267

@albertored albertored linked a pull request Sep 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant