Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably unintentional proto field ID gaps in the Sample message in pprofextended #562

Open
aalexand opened this issue May 18, 2024 · 0 comments
Assignees

Comments

@aalexand
Copy link

Reordering things:

message Sample {
  repeated uint64 location_index = 1;
  repeated int64 value = 2;
  repeated Label label = 3;

  // fields 4, 5, 6 are missing.

  uint64 locations_start_index = 7;
  uint64 locations_length = 8;
  uint32 stacktrace_id_index = 9;
  repeated uint64 attributes = 10;

  // field 11 is missing

  uint64 link = 12;
  repeated uint64 timestamps_unix_nano = 13;
}

This seems unintentional.

@petethepig FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants