Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify requirements to meet before EntityRef is added to the Resource #603

Open
1 of 5 tasks
tigrannajaryan opened this issue Nov 21, 2024 · 2 comments
Open
1 of 5 tasks

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Nov 21, 2024

The following is the checklist to complete before we add the entity_refs field to the Resource.

  • Functionality of id_attr_keys and descr_attr_keys fields meets our modeling needs (including confirming it can be modelled efficiently performance-wise in pdata).
  • Name of the added field in the Resource is confirmed. We committed to entity_refs.
  • Names of the fields in the ResourceEntityRef message are confirmed.
  • The concerns with Go prototype should be resolved (@MrAlias has a concern that it is a breaking change - need to make sure it it is done in a non-breaking manner).
  • Check the payload size increase.
@tigrannajaryan
Copy link
Member Author

@jsuereth @dmitryax FYI

@feldentm-SAP
Copy link

I think we should also discuss

  • different identification styles (pod_name vs pod_uid) as id_attr
  • different identification context encoding (within cluster vs global)

Since I joined the group recently, I cannot judge the state of the two discussions. However, all options I currently see would affect how we encode entities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants