-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aggregation_temporality to be an enum #1742
Comments
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
@xuan-cao-swi - I looked into this a little more after the SIG. The class I was thinking of as an example is is OpenTelemetry::Trace::Status. In the spec, the Set Status API only has three valid options. The class is used like this:
The class method is always called to get a valid status. @arielvalentin, is something like this what you were initially thinking of when you recommended an enum for aggregation temporality or did you have something else in mind? |
Thanks for the example! I'd like to contribute on this based on the structure of OpenTelemetry::Trace::Status. |
@xuan-cao-swi, sounds great! I've assigned you to the issue. |
The
aggregation_temporality
option in the Sum and ExplicitBucketHistogram aggregations is currently open-ended. The only spec'd options for this are:delta
and:cumulative
. Let's update the assignment to use an enum instead.Relates to #1555
The text was updated successfully, but these errors were encountered: