Fix where clause of `OpenIddictEntityFrameworkCoreAuthorizationStore#FindByApplicationIdAsync #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FindByApplicationIdAsync` Before that fix, when OppenIddict was configured with a custom application id type like `Guid`, the where-clause sent to the database was literally `where False`, because the type of `application.Id` was incompatible with the type of the erroneously used variable `identifier`.
|
Thanks for your PR! Nice catch, I'll make sure it ships as part of the next 6.x release (likely a patch version). |
simon-wacker
deleted the
fix-where-clause-when-finding-authorizations-by-application-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that fix, when OppenIddict was configured with a custom application id type like
Guid, the where-clause sent to the database was literallywhere False, because the type ofapplication.Idwas incompatible with the type of the erroneously used variableidentifier.