Build error of zfs 2.2.7 on 4.19.325

[philmmanjaro]

System information

Type	Version/Name
Distribution Name	Manjaro
Distribution Version	24.2
Kernel Version	4.19.325
Architecture	x86_64
OpenZFS Version	2.2.7

Describe the problem you're observing

zfs 2.2.7 can't be compiled with 4.19.325

Describe how to reproduce the problem

Include any warning/errors/backtraces from the system logs

Build log:

DKMS make.log for zfs/2.2.7 for kernel 4.19.325-1-MANJARO (x86_64)
Thu Dec 12 10:18:13 AM UTC 2024
make: Entering directory '/build/linux419-zfs/src/zfs/2.2.7/build/module'
mkdir -p os/linux/spl/
mkdir -p avl/ icp/ icp/algs/aes/ icp/algs/blake3/ icp/algs/edonr/ icp/algs/modes/ icp/algs/sha2/ icp/algs/skein/ icp/api/ icp/asm-aarch64/blake3/ icp/asm-aarch64/sha2/ icp/asm-arm/sha2/ icp/asm-ppc64/blake3/ icp/asm-ppc64/sha2/ icp/asm-x86_64/aes/ icp/asm-x86_64/blake3/ icp/asm-x86_64/modes/ icp/asm-x86_64/sha2/ icp/core/ icp/io/ icp/spi/ lua/ lua/setjmp/ nvpair/ os/linux/zfs/ unicode/ zcommon/ zfs/ zstd/ zstd/lib/common/ zstd/lib/compress/ zstd/lib/decompress/
make -C /usr/lib/modules/4.19.325-1-MANJARO/build  \
	  \
	M="$PWD"  CONFIG_ZFS=m modules
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-atomic.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-condvar.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-cred.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-err.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-generic.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-kmem-cache.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-kmem.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-kstat.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-proc.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-procfs-list.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-shrinker.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-taskq.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-thread.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-trace.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-tsd.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-vmem.o
  CC [M]  /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-xdr.o
/build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-thread.c: In function ‘issig’:
/build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-thread.c:178:28: error: passing argument 1 of ‘dequeue_signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  178 |         if (dequeue_signal(&set, &__info, &__type) != 0) {
      |                            ^~~~
      |                            |
      |                            sigset_t *
In file included from /build/linux419-zfs/src/zfs/2.2.7/build/include/os/linux/spl/sys/signal.h:28,
                 from /build/linux419-zfs/src/zfs/2.2.7/build/include/os/linux/spl/sys/sysmacros.h:33,
                 from /build/linux419-zfs/src/zfs/2.2.7/build/include/os/linux/spl/sys/thread.h:32,
                 from /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-thread.c:26:
./include/linux/sched/signal.h:273:47: note: expected ‘struct task_struct *’ but argument is of type ‘sigset_t *’
  273 | extern int dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info);
      |                           ~~~~~~~~~~~~~~~~~~~~^~~
/build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-thread.c:178:34: error: passing argument 2 of ‘dequeue_signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  178 |         if (dequeue_signal(&set, &__info, &__type) != 0) {
      |                                  ^~~~~~~
      |                                  |
      |                                  spl_kernel_siginfo_t * {aka struct siginfo *}
./include/linux/sched/signal.h:273:62: note: expected ‘sigset_t *’ but argument is of type ‘spl_kernel_siginfo_t *’ {aka ‘struct siginfo *’}
  273 | extern int dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info);
      |                                                    ~~~~~~~~~~^~~~
/build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-thread.c:178:43: error: passing argument 3 of ‘dequeue_signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  178 |         if (dequeue_signal(&set, &__info, &__type) != 0) {
      |                                           ^~~~~~~
      |                                           |
      |                                           enum pid_type *
./include/linux/sched/signal.h:273:79: note: expected ‘siginfo_t *’ {aka ‘struct siginfo *’} but argument is of type ‘enum pid_type *’
  273 | extern int dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info);
      |                                                                    ~~~~~~~~~~~^~~~
make[2]: *** [scripts/Makefile.build:303: /build/linux419-zfs/src/zfs/2.2.7/build/module/os/linux/spl/spl-thread.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1564: _module_/build/linux419-zfs/src/zfs/2.2.7/build/module] Error 2
make: *** [Makefile:56: modules-Linux] Error 2
make: Leaving directory '/build/linux419-zfs/src/zfs/2.2.7/build/module'

[philmmanjaro]

fixed via 3488cdb

[AllKind]

@tonyhutter did that fix slip through the cracks?

[n0xena]

4.19 goes EOL and the end of this year
why running such an old kernel anyway? at least go for 5.4 which goes EOL at the end of next year

[behlendorf]

@philmmanjaro thanks for reporting this and running down the missed commit. We'll queue it up for inclusion in 2.2.8. Until then you'll need to carry it locally if you need to run 4.19.