Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve app_offline.htm behavior to ensure successful builds #23

Open
ankitkumarr opened this issue Aug 8, 2019 · 2 comments
Open

Improve app_offline.htm behavior to ensure successful builds #23

ankitkumarr opened this issue Aug 8, 2019 · 2 comments

Comments

@ankitkumarr
Copy link
Member

app_offline.htm gets created during a kudusync copy and some times, it may fail to remove. We need to discuss and see if there's a better approach.

cc: @suwatch

@suwatch
Copy link
Member

suwatch commented Aug 9, 2019

Thanks for tracking this! Let's brainstorm some idea this week.

@ankitkumarr
Copy link
Member Author

Next steps --

  1. Find evidence of cases where this happened
  2. Set up Alerts for this
  3. Finalize on the design.
    One of Suwat's suggestion was going with a two-phase commit, where the first step involves dropping a file somewhere outside of wwwroot, indicating that a app_offline.htm may be created. Periodically, kudu could check for this file and if present, remove app_offline.htm, keeping in mind any ongoing deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants