Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more indication on hover of the selected link in the top bar #2070

Open
loichuder opened this issue Dec 6, 2024 · 3 comments
Open

No more indication on hover of the selected link in the top bar #2070

loichuder opened this issue Dec 6, 2024 · 3 comments
Labels
needs: discussion Needs discussion before an implementation can be made tag: design Items related to design tasks or improvements

Comments

@loichuder
Copy link

loichuder commented Dec 6, 2024

Apologies if this is a duplicate and if the question was already answered elsewhere.

First of all, thanks for the nice theme that takes accessibility into account. Linked to this, I was quite surprised that there is no more indication when hovering the selected link in the top bar:

Screencast.from.06-12-2024.11.30.33.webm

From https://pydata-sphinx-theme.readthedocs.io/en/v0.15.4/community/index.html

Before (14.x), there was an double underline. Was it removed intentionally ?

Thanks !

@trallard
Copy link
Collaborator

Hey @loichuder 👋🏽 yes, we have continued to work on the interactive elements, and this was one where folks mentioned the previous behavior being a bit disruptive.

@smeragoel recently reworked these designs, and mixed states (hover + current, focus + hover) were quite problematic to get right, so in the interim, we removed this current + hover.
We might reevaluate this in the future, but right now we are focusing on other items.

@trallard trallard added the tag: design Items related to design tasks or improvements label Dec 10, 2024
@loichuder
Copy link
Author

True, that is always tricky to get right. Thanks for the answer 👍

@smeragoel
Copy link
Contributor

smeragoel commented Dec 10, 2024

Hi @loichuder!

While @trallard has already provided the answer, I wanted to mention how valuable it is that you reported this. It’s really helpful for us to understand how users are engaging with the theme and such feedback helps us make the theme more accessible and user-friendly as we continue to work on it.

Thanks again for taking the time to share your thoughts! 🌟

@trallard trallard added the needs: discussion Needs discussion before an implementation can be made label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion Needs discussion before an implementation can be made tag: design Items related to design tasks or improvements
Projects
None yet
Development

No branches or pull requests

3 participants