-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize --find-links=<path-to-dir> #12327
Optimize --find-links=<path-to-dir> #12327
Conversation
Optimizations strategies in this PR might be able to be applied to other ways Pip collects links. I will take a look at them when I have a way to consistently benchmarking those. |
Profiling the The biggest hotspot under this branch for that use case is now |
f5a472e
to
e0624fa
Compare
Updated to significantly simplify the new class Also cleaned the commit history so it's just 3 commits. |
I do intend to try to review this at some point, but life has been hectic, so I can't promise when I'll be able to get to it. |
Absolutely no rush, I don't consider this PR particularly critical in of itself. But I planned to benchmark Pip's other ways of collecting packages and seeing if I can reuse the same approaches to improve their performances as well. And it also it helps surface other |
e0624fa
to
53862de
Compare
478e38c
to
dc0b313
Compare
Thanks for merging, I will keep an eye out on the issue tracker after the next Pip release, this will probably have an unintended effect on someone's unusual workflow. |
Updates the requirements on [pip](https://github.com/pypa/pip) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>24.0 (2024-02-03)</h1> <h2>Features</h2> <ul> <li>Retry on HTTP status code 502 (<code>[#11843](pypa/pip#11843) <https://github.com/pypa/pip/issues/11843></code>_)</li> <li>Automatically use the setuptools PEP 517 build backend when <code>--config-settings</code> is used for projects without <code>pyproject.toml</code>. (<code>[#11915](pypa/pip#11915) <https://github.com/pypa/pip/issues/11915></code>_)</li> <li>Make pip freeze and pip uninstall of legacy editable installs of packages whose name contains <code>_</code> compatible with <code>setuptools>=69.0.3</code>. (<code>[#12477](pypa/pip#12477) <https://github.com/pypa/pip/issues/12477></code>_)</li> <li>Support per requirement <code>--config-settings</code> for editable installs. (<code>[#12480](pypa/pip#12480) <https://github.com/pypa/pip/issues/12480></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Optimized usage of <code>--find-links=<path-to-dir></code>, by only scanning the relevant directory once, only considering file names that are valid wheel or sdist names, and only considering files in the directory that are related to the install. (<code>[#12327](pypa/pip#12327) <https://github.com/pypa/pip/issues/12327></code>_)</li> <li>Removed <code>wheel</code> from the <code>[build-system].requires</code> list fallback that is used when <code>pyproject.toml</code> is absent. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> </ul> <h2>Vendored Libraries</h2> <ul> <li>Upgrade distlib to 0.3.8</li> </ul> <h2>Improved Documentation</h2> <ul> <li>Fix explanation of how PIP_CONFIG_FILE works (<code>[#11815](pypa/pip#11815) <https://github.com/pypa/pip/issues/11815></code>_)</li> <li>Fix outdated pip install argument description in documentation. (<code>[#12417](pypa/pip#12417) <https://github.com/pypa/pip/issues/12417></code>_)</li> <li>Replace some links to PEPs with links to the canonical specifications on the :doc:<code>pypug:index</code> (<code>[#12434](pypa/pip#12434) <https://github.com/pypa/pip/issues/12434></code>_)</li> <li>Updated the <code>pyproject.toml</code> document to stop suggesting to depend on <code>wheel</code> as a build dependency directly. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> <li>Update supported interpreters in development docs (<code>[#12475](pypa/pip#12475) <https://github.com/pypa/pip/issues/12475></code>_)</li> </ul> <h2>Process</h2> <ul> <li>Most project metadata is now defined statically via pip's <code>pyproject.toml</code> file.</li> </ul> <h1>23.3.2 (2023-12-17)</h1> <h2>Bug Fixes</h2> <ul> <li>Fix a bug in extras handling for link requirements (<code>[#12372](pypa/pip#12372) <https://github.com/pypa/pip/issues/12372></code>_)</li> <li>Fix mercurial revision "parse error": use <code>--rev={ref}</code> instead of <code>-r={ref}</code> (<code>[#12373](pypa/pip#12373) <https://github.com/pypa/pip/issues/12373></code>_)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/ef78c129b1a966dbbbdb8ebfffc43723e89110d1"><code>ef78c12</code></a> Tweak NEWS.rst</li> <li><a href="https://github.com/pypa/pip/commit/6681c02710b81278adb874007286960108867768"><code>6681c02</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/ef56d47f90eb3881dba5134241de94d504576f1b"><code>ef56d47</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/53e5f192bab27cad793e9dbfd9849717c1ed3617"><code>53e5f19</code></a> Tweak news before release</li> <li><a href="https://github.com/pypa/pip/commit/456db06c0312b6ce971d7c7a97806be8868b79b7"><code>456db06</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12507">#12507</a> from jeanas/mailmap</li> <li><a href="https://github.com/pypa/pip/commit/0b93dfc7c319449a71c50233c4fb344f9c24a668"><code>0b93dfc</code></a> Add mailmap entry for <a href="https://github.com/jeanas"><code>@jeanas</code></a></li> <li><a href="https://github.com/pypa/pip/commit/c0801efcb5251d5704d67dd77dc77b5499d900c5"><code>c0801ef</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12500">#12500</a> from bdraco/add_502</li> <li><a href="https://github.com/pypa/pip/commit/aa930c49983e11c89d00d959c5d412a3211c2cbf"><code>aa930c4</code></a> Update src/pip/_internal/network/session.py</li> <li><a href="https://github.com/pypa/pip/commit/99a82b7e49a1657d18c8453c42f7eff971ce1cb5"><code>99a82b7</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12494">#12494</a> from sbidoul/pass-config-settings-to-editable-in-re...</li> <li><a href="https://github.com/pypa/pip/commit/ff30ba86c1d04ade84843b02d251f97f1a2c3c2c"><code>ff30ba8</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12501">#12501</a> from VladimirFokow/fix-small-typo</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/0.3...24.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s/@jsii/python-runtime (#4416) Updates the requirements on [pip](https://github.com/pypa/pip) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>24.0 (2024-02-03)</h1> <h2>Features</h2> <ul> <li>Retry on HTTP status code 502 (<code>[#11843](pypa/pip#11843) <https://github.com/pypa/pip/issues/11843></code>_)</li> <li>Automatically use the setuptools PEP 517 build backend when <code>--config-settings</code> is used for projects without <code>pyproject.toml</code>. (<code>[#11915](pypa/pip#11915) <https://github.com/pypa/pip/issues/11915></code>_)</li> <li>Make pip freeze and pip uninstall of legacy editable installs of packages whose name contains <code>_</code> compatible with <code>setuptools>=69.0.3</code>. (<code>[#12477](pypa/pip#12477) <https://github.com/pypa/pip/issues/12477></code>_)</li> <li>Support per requirement <code>--config-settings</code> for editable installs. (<code>[#12480](pypa/pip#12480) <https://github.com/pypa/pip/issues/12480></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Optimized usage of <code>--find-links=<path-to-dir></code>, by only scanning the relevant directory once, only considering file names that are valid wheel or sdist names, and only considering files in the directory that are related to the install. (<code>[#12327](pypa/pip#12327) <https://github.com/pypa/pip/issues/12327></code>_)</li> <li>Removed <code>wheel</code> from the <code>[build-system].requires</code> list fallback that is used when <code>pyproject.toml</code> is absent. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> </ul> <h2>Vendored Libraries</h2> <ul> <li>Upgrade distlib to 0.3.8</li> </ul> <h2>Improved Documentation</h2> <ul> <li>Fix explanation of how PIP_CONFIG_FILE works (<code>[#11815](pypa/pip#11815) <https://github.com/pypa/pip/issues/11815></code>_)</li> <li>Fix outdated pip install argument description in documentation. (<code>[#12417](pypa/pip#12417) <https://github.com/pypa/pip/issues/12417></code>_)</li> <li>Replace some links to PEPs with links to the canonical specifications on the :doc:<code>pypug:index</code> (<code>[#12434](pypa/pip#12434) <https://github.com/pypa/pip/issues/12434></code>_)</li> <li>Updated the <code>pyproject.toml</code> document to stop suggesting to depend on <code>wheel</code> as a build dependency directly. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> <li>Update supported interpreters in development docs (<code>[#12475](pypa/pip#12475) <https://github.com/pypa/pip/issues/12475></code>_)</li> </ul> <h2>Process</h2> <ul> <li>Most project metadata is now defined statically via pip's <code>pyproject.toml</code> file.</li> </ul> <h1>23.3.2 (2023-12-17)</h1> <h2>Bug Fixes</h2> <ul> <li>Fix a bug in extras handling for link requirements (<code>[#12372](pypa/pip#12372) <https://github.com/pypa/pip/issues/12372></code>_)</li> <li>Fix mercurial revision "parse error": use <code>--rev={ref}</code> instead of <code>-r={ref}</code> (<code>[#12373](pypa/pip#12373) <https://github.com/pypa/pip/issues/12373></code>_)</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/ef78c129b1a966dbbbdb8ebfffc43723e89110d1"><code>ef78c12</code></a> Tweak NEWS.rst</li> <li><a href="https://github.com/pypa/pip/commit/6681c02710b81278adb874007286960108867768"><code>6681c02</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/ef56d47f90eb3881dba5134241de94d504576f1b"><code>ef56d47</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/53e5f192bab27cad793e9dbfd9849717c1ed3617"><code>53e5f19</code></a> Tweak news before release</li> <li><a href="https://github.com/pypa/pip/commit/456db06c0312b6ce971d7c7a97806be8868b79b7"><code>456db06</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12507">#12507</a> from jeanas/mailmap</li> <li><a href="https://github.com/pypa/pip/commit/0b93dfc7c319449a71c50233c4fb344f9c24a668"><code>0b93dfc</code></a> Add mailmap entry for <a href="https://github.com/jeanas"><code>@jeanas</code></a></li> <li><a href="https://github.com/pypa/pip/commit/c0801efcb5251d5704d67dd77dc77b5499d900c5"><code>c0801ef</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12500">#12500</a> from bdraco/add_502</li> <li><a href="https://github.com/pypa/pip/commit/aa930c49983e11c89d00d959c5d412a3211c2cbf"><code>aa930c4</code></a> Update src/pip/_internal/network/session.py</li> <li><a href="https://github.com/pypa/pip/commit/99a82b7e49a1657d18c8453c42f7eff971ce1cb5"><code>99a82b7</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12494">#12494</a> from sbidoul/pass-config-settings-to-editable-in-re...</li> <li><a href="https://github.com/pypa/pip/commit/ff30ba86c1d04ade84843b02d251f97f1a2c3c2c"><code>ff30ba8</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12501">#12501</a> from VladimirFokow/fix-small-typo</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/23.3...24.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…k/test/generated-code (#4417) Bumps [pip](https://github.com/pypa/pip) from 23.3.2 to 24.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>24.0 (2024-02-03)</h1> <h2>Features</h2> <ul> <li>Retry on HTTP status code 502 (<code>[#11843](pypa/pip#11843) <https://github.com/pypa/pip/issues/11843></code>_)</li> <li>Automatically use the setuptools PEP 517 build backend when <code>--config-settings</code> is used for projects without <code>pyproject.toml</code>. (<code>[#11915](pypa/pip#11915) <https://github.com/pypa/pip/issues/11915></code>_)</li> <li>Make pip freeze and pip uninstall of legacy editable installs of packages whose name contains <code>_</code> compatible with <code>setuptools>=69.0.3</code>. (<code>[#12477](pypa/pip#12477) <https://github.com/pypa/pip/issues/12477></code>_)</li> <li>Support per requirement <code>--config-settings</code> for editable installs. (<code>[#12480](pypa/pip#12480) <https://github.com/pypa/pip/issues/12480></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Optimized usage of <code>--find-links=<path-to-dir></code>, by only scanning the relevant directory once, only considering file names that are valid wheel or sdist names, and only considering files in the directory that are related to the install. (<code>[#12327](pypa/pip#12327) <https://github.com/pypa/pip/issues/12327></code>_)</li> <li>Removed <code>wheel</code> from the <code>[build-system].requires</code> list fallback that is used when <code>pyproject.toml</code> is absent. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> </ul> <h2>Vendored Libraries</h2> <ul> <li>Upgrade distlib to 0.3.8</li> </ul> <h2>Improved Documentation</h2> <ul> <li>Fix explanation of how PIP_CONFIG_FILE works (<code>[#11815](pypa/pip#11815) <https://github.com/pypa/pip/issues/11815></code>_)</li> <li>Fix outdated pip install argument description in documentation. (<code>[#12417](pypa/pip#12417) <https://github.com/pypa/pip/issues/12417></code>_)</li> <li>Replace some links to PEPs with links to the canonical specifications on the :doc:<code>pypug:index</code> (<code>[#12434](pypa/pip#12434) <https://github.com/pypa/pip/issues/12434></code>_)</li> <li>Updated the <code>pyproject.toml</code> document to stop suggesting to depend on <code>wheel</code> as a build dependency directly. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> <li>Update supported interpreters in development docs (<code>[#12475](pypa/pip#12475) <https://github.com/pypa/pip/issues/12475></code>_)</li> </ul> <h2>Process</h2> <ul> <li>Most project metadata is now defined statically via pip's <code>pyproject.toml</code> file.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/ef78c129b1a966dbbbdb8ebfffc43723e89110d1"><code>ef78c12</code></a> Tweak NEWS.rst</li> <li><a href="https://github.com/pypa/pip/commit/6681c02710b81278adb874007286960108867768"><code>6681c02</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/ef56d47f90eb3881dba5134241de94d504576f1b"><code>ef56d47</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/53e5f192bab27cad793e9dbfd9849717c1ed3617"><code>53e5f19</code></a> Tweak news before release</li> <li><a href="https://github.com/pypa/pip/commit/456db06c0312b6ce971d7c7a97806be8868b79b7"><code>456db06</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12507">#12507</a> from jeanas/mailmap</li> <li><a href="https://github.com/pypa/pip/commit/0b93dfc7c319449a71c50233c4fb344f9c24a668"><code>0b93dfc</code></a> Add mailmap entry for <a href="https://github.com/jeanas"><code>@jeanas</code></a></li> <li><a href="https://github.com/pypa/pip/commit/c0801efcb5251d5704d67dd77dc77b5499d900c5"><code>c0801ef</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12500">#12500</a> from bdraco/add_502</li> <li><a href="https://github.com/pypa/pip/commit/aa930c49983e11c89d00d959c5d412a3211c2cbf"><code>aa930c4</code></a> Update src/pip/_internal/network/session.py</li> <li><a href="https://github.com/pypa/pip/commit/99a82b7e49a1657d18c8453c42f7eff971ce1cb5"><code>99a82b7</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12494">#12494</a> from sbidoul/pass-config-settings-to-editable-in-re...</li> <li><a href="https://github.com/pypa/pip/commit/ff30ba86c1d04ade84843b02d251f97f1a2c3c2c"><code>ff30ba8</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12501">#12501</a> from VladimirFokow/fix-small-typo</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/23.3.2...24.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=23.3.2&new-version=24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Bumps [pip](https://github.com/pypa/pip) from 23.3.2 to 24.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>24.0 (2024-02-03)</h1> <h2>Features</h2> <ul> <li>Retry on HTTP status code 502 (<code>[#11843](pypa/pip#11843) <https://github.com/pypa/pip/issues/11843></code>_)</li> <li>Automatically use the setuptools PEP 517 build backend when <code>--config-settings</code> is used for projects without <code>pyproject.toml</code>. (<code>[#11915](pypa/pip#11915) <https://github.com/pypa/pip/issues/11915></code>_)</li> <li>Make pip freeze and pip uninstall of legacy editable installs of packages whose name contains <code>_</code> compatible with <code>setuptools>=69.0.3</code>. (<code>[#12477](pypa/pip#12477) <https://github.com/pypa/pip/issues/12477></code>_)</li> <li>Support per requirement <code>--config-settings</code> for editable installs. (<code>[#12480](pypa/pip#12480) <https://github.com/pypa/pip/issues/12480></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Optimized usage of <code>--find-links=<path-to-dir></code>, by only scanning the relevant directory once, only considering file names that are valid wheel or sdist names, and only considering files in the directory that are related to the install. (<code>[#12327](pypa/pip#12327) <https://github.com/pypa/pip/issues/12327></code>_)</li> <li>Removed <code>wheel</code> from the <code>[build-system].requires</code> list fallback that is used when <code>pyproject.toml</code> is absent. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> </ul> <h2>Vendored Libraries</h2> <ul> <li>Upgrade distlib to 0.3.8</li> </ul> <h2>Improved Documentation</h2> <ul> <li>Fix explanation of how PIP_CONFIG_FILE works (<code>[#11815](pypa/pip#11815) <https://github.com/pypa/pip/issues/11815></code>_)</li> <li>Fix outdated pip install argument description in documentation. (<code>[#12417](pypa/pip#12417) <https://github.com/pypa/pip/issues/12417></code>_)</li> <li>Replace some links to PEPs with links to the canonical specifications on the :doc:<code>pypug:index</code> (<code>[#12434](pypa/pip#12434) <https://github.com/pypa/pip/issues/12434></code>_)</li> <li>Updated the <code>pyproject.toml</code> document to stop suggesting to depend on <code>wheel</code> as a build dependency directly. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> <li>Update supported interpreters in development docs (<code>[#12475](pypa/pip#12475) <https://github.com/pypa/pip/issues/12475></code>_)</li> </ul> <h2>Process</h2> <ul> <li>Most project metadata is now defined statically via pip's <code>pyproject.toml</code> file.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/ef78c129b1a966dbbbdb8ebfffc43723e89110d1"><code>ef78c12</code></a> Tweak NEWS.rst</li> <li><a href="https://github.com/pypa/pip/commit/6681c02710b81278adb874007286960108867768"><code>6681c02</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/ef56d47f90eb3881dba5134241de94d504576f1b"><code>ef56d47</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/53e5f192bab27cad793e9dbfd9849717c1ed3617"><code>53e5f19</code></a> Tweak news before release</li> <li><a href="https://github.com/pypa/pip/commit/456db06c0312b6ce971d7c7a97806be8868b79b7"><code>456db06</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12507">#12507</a> from jeanas/mailmap</li> <li><a href="https://github.com/pypa/pip/commit/0b93dfc7c319449a71c50233c4fb344f9c24a668"><code>0b93dfc</code></a> Add mailmap entry for <a href="https://github.com/jeanas"><code>@jeanas</code></a></li> <li><a href="https://github.com/pypa/pip/commit/c0801efcb5251d5704d67dd77dc77b5499d900c5"><code>c0801ef</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12500">#12500</a> from bdraco/add_502</li> <li><a href="https://github.com/pypa/pip/commit/aa930c49983e11c89d00d959c5d412a3211c2cbf"><code>aa930c4</code></a> Update src/pip/_internal/network/session.py</li> <li><a href="https://github.com/pypa/pip/commit/99a82b7e49a1657d18c8453c42f7eff971ce1cb5"><code>99a82b7</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12494">#12494</a> from sbidoul/pass-config-settings-to-editable-in-re...</li> <li><a href="https://github.com/pypa/pip/commit/ff30ba86c1d04ade84843b02d251f97f1a2c3c2c"><code>ff30ba8</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12501">#12501</a> from VladimirFokow/fix-small-typo</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/23.3.2...24.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=23.3.2&new-version=24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pip](https://github.com/pypa/pip) from 23.3.2 to 24.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>24.0 (2024-02-03)</h1> <h2>Features</h2> <ul> <li>Retry on HTTP status code 502 (<code>[#11843](pypa/pip#11843) <https://github.com/pypa/pip/issues/11843></code>_)</li> <li>Automatically use the setuptools PEP 517 build backend when <code>--config-settings</code> is used for projects without <code>pyproject.toml</code>. (<code>[#11915](pypa/pip#11915) <https://github.com/pypa/pip/issues/11915></code>_)</li> <li>Make pip freeze and pip uninstall of legacy editable installs of packages whose name contains <code>_</code> compatible with <code>setuptools>=69.0.3</code>. (<code>[#12477](pypa/pip#12477) <https://github.com/pypa/pip/issues/12477></code>_)</li> <li>Support per requirement <code>--config-settings</code> for editable installs. (<code>[#12480](pypa/pip#12480) <https://github.com/pypa/pip/issues/12480></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Optimized usage of <code>--find-links=<path-to-dir></code>, by only scanning the relevant directory once, only considering file names that are valid wheel or sdist names, and only considering files in the directory that are related to the install. (<code>[#12327](pypa/pip#12327) <https://github.com/pypa/pip/issues/12327></code>_)</li> <li>Removed <code>wheel</code> from the <code>[build-system].requires</code> list fallback that is used when <code>pyproject.toml</code> is absent. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> </ul> <h2>Vendored Libraries</h2> <ul> <li>Upgrade distlib to 0.3.8</li> </ul> <h2>Improved Documentation</h2> <ul> <li>Fix explanation of how PIP_CONFIG_FILE works (<code>[#11815](pypa/pip#11815) <https://github.com/pypa/pip/issues/11815></code>_)</li> <li>Fix outdated pip install argument description in documentation. (<code>[#12417](pypa/pip#12417) <https://github.com/pypa/pip/issues/12417></code>_)</li> <li>Replace some links to PEPs with links to the canonical specifications on the :doc:<code>pypug:index</code> (<code>[#12434](pypa/pip#12434) <https://github.com/pypa/pip/issues/12434></code>_)</li> <li>Updated the <code>pyproject.toml</code> document to stop suggesting to depend on <code>wheel</code> as a build dependency directly. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> <li>Update supported interpreters in development docs (<code>[#12475](pypa/pip#12475) <https://github.com/pypa/pip/issues/12475></code>_)</li> </ul> <h2>Process</h2> <ul> <li>Most project metadata is now defined statically via pip's <code>pyproject.toml</code> file.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/ef78c129b1a966dbbbdb8ebfffc43723e89110d1"><code>ef78c12</code></a> Tweak NEWS.rst</li> <li><a href="https://github.com/pypa/pip/commit/6681c02710b81278adb874007286960108867768"><code>6681c02</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/ef56d47f90eb3881dba5134241de94d504576f1b"><code>ef56d47</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/53e5f192bab27cad793e9dbfd9849717c1ed3617"><code>53e5f19</code></a> Tweak news before release</li> <li><a href="https://github.com/pypa/pip/commit/456db06c0312b6ce971d7c7a97806be8868b79b7"><code>456db06</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12507">#12507</a> from jeanas/mailmap</li> <li><a href="https://github.com/pypa/pip/commit/0b93dfc7c319449a71c50233c4fb344f9c24a668"><code>0b93dfc</code></a> Add mailmap entry for <a href="https://github.com/jeanas"><code>@jeanas</code></a></li> <li><a href="https://github.com/pypa/pip/commit/c0801efcb5251d5704d67dd77dc77b5499d900c5"><code>c0801ef</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12500">#12500</a> from bdraco/add_502</li> <li><a href="https://github.com/pypa/pip/commit/aa930c49983e11c89d00d959c5d412a3211c2cbf"><code>aa930c4</code></a> Update src/pip/_internal/network/session.py</li> <li><a href="https://github.com/pypa/pip/commit/99a82b7e49a1657d18c8453c42f7eff971ce1cb5"><code>99a82b7</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12494">#12494</a> from sbidoul/pass-config-settings-to-editable-in-re...</li> <li><a href="https://github.com/pypa/pip/commit/ff30ba86c1d04ade84843b02d251f97f1a2c3c2c"><code>ff30ba8</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12501">#12501</a> from VladimirFokow/fix-small-typo</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/23.3.2...24.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=23.3.2&new-version=24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Bumps [pip](https://github.com/pypa/pip) from 23.3.2 to 24.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>24.0 (2024-02-03)</h1> <h2>Features</h2> <ul> <li>Retry on HTTP status code 502 (<code>[#11843](pypa/pip#11843) <https://github.com/pypa/pip/issues/11843></code>_)</li> <li>Automatically use the setuptools PEP 517 build backend when <code>--config-settings</code> is used for projects without <code>pyproject.toml</code>. (<code>[#11915](pypa/pip#11915) <https://github.com/pypa/pip/issues/11915></code>_)</li> <li>Make pip freeze and pip uninstall of legacy editable installs of packages whose name contains <code>_</code> compatible with <code>setuptools>=69.0.3</code>. (<code>[#12477](pypa/pip#12477) <https://github.com/pypa/pip/issues/12477></code>_)</li> <li>Support per requirement <code>--config-settings</code> for editable installs. (<code>[#12480](pypa/pip#12480) <https://github.com/pypa/pip/issues/12480></code>_)</li> </ul> <h2>Bug Fixes</h2> <ul> <li>Optimized usage of <code>--find-links=<path-to-dir></code>, by only scanning the relevant directory once, only considering file names that are valid wheel or sdist names, and only considering files in the directory that are related to the install. (<code>[#12327](pypa/pip#12327) <https://github.com/pypa/pip/issues/12327></code>_)</li> <li>Removed <code>wheel</code> from the <code>[build-system].requires</code> list fallback that is used when <code>pyproject.toml</code> is absent. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> </ul> <h2>Vendored Libraries</h2> <ul> <li>Upgrade distlib to 0.3.8</li> </ul> <h2>Improved Documentation</h2> <ul> <li>Fix explanation of how PIP_CONFIG_FILE works (<code>[#11815](pypa/pip#11815) <https://github.com/pypa/pip/issues/11815></code>_)</li> <li>Fix outdated pip install argument description in documentation. (<code>[#12417](pypa/pip#12417) <https://github.com/pypa/pip/issues/12417></code>_)</li> <li>Replace some links to PEPs with links to the canonical specifications on the :doc:<code>pypug:index</code> (<code>[#12434](pypa/pip#12434) <https://github.com/pypa/pip/issues/12434></code>_)</li> <li>Updated the <code>pyproject.toml</code> document to stop suggesting to depend on <code>wheel</code> as a build dependency directly. (<code>[#12449](pypa/pip#12449) <https://github.com/pypa/pip/issues/12449></code>_)</li> <li>Update supported interpreters in development docs (<code>[#12475](pypa/pip#12475) <https://github.com/pypa/pip/issues/12475></code>_)</li> </ul> <h2>Process</h2> <ul> <li>Most project metadata is now defined statically via pip's <code>pyproject.toml</code> file.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/ef78c129b1a966dbbbdb8ebfffc43723e89110d1"><code>ef78c12</code></a> Tweak NEWS.rst</li> <li><a href="https://github.com/pypa/pip/commit/6681c02710b81278adb874007286960108867768"><code>6681c02</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/ef56d47f90eb3881dba5134241de94d504576f1b"><code>ef56d47</code></a> Update AUTHORS.txt</li> <li><a href="https://github.com/pypa/pip/commit/53e5f192bab27cad793e9dbfd9849717c1ed3617"><code>53e5f19</code></a> Tweak news before release</li> <li><a href="https://github.com/pypa/pip/commit/456db06c0312b6ce971d7c7a97806be8868b79b7"><code>456db06</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12507">#12507</a> from jeanas/mailmap</li> <li><a href="https://github.com/pypa/pip/commit/0b93dfc7c319449a71c50233c4fb344f9c24a668"><code>0b93dfc</code></a> Add mailmap entry for <a href="https://github.com/jeanas"><code>@jeanas</code></a></li> <li><a href="https://github.com/pypa/pip/commit/c0801efcb5251d5704d67dd77dc77b5499d900c5"><code>c0801ef</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12500">#12500</a> from bdraco/add_502</li> <li><a href="https://github.com/pypa/pip/commit/aa930c49983e11c89d00d959c5d412a3211c2cbf"><code>aa930c4</code></a> Update src/pip/_internal/network/session.py</li> <li><a href="https://github.com/pypa/pip/commit/99a82b7e49a1657d18c8453c42f7eff971ce1cb5"><code>99a82b7</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12494">#12494</a> from sbidoul/pass-config-settings-to-editable-in-re...</li> <li><a href="https://github.com/pypa/pip/commit/ff30ba86c1d04ade84843b02d251f97f1a2c3c2c"><code>ff30ba8</code></a> Merge pull request <a href="https://redirect.github.com/pypa/pip/issues/12501">#12501</a> from VladimirFokow/fix-small-typo</li> <li>Additional commits viewable in <a href="https://github.com/pypa/pip/compare/23.3.2...24.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pip&package-manager=pip&previous-version=23.3.2&new-version=24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixes #12320 by implementing the optimization strategy:
_FlatDirectorySource
only scan the relevant path once (instead of currently which is 2*(number of projects pip considers installing)) by caching the result of scanningFurther optimizations were added:
Path
construction for only interating directory, as the result was just stingified anyway_FlatDirectorySource
only considers file names in the path that have a valid sdist of wheel name_FlatDirectorySource
only considers file names that are relevant to the current project Pip is considering, which produces a huge speed up where there are a lot of projects to be installedTo make sure this optimization did not produce unintended slowdowns I tried 4 different requirements on my machine using the steps outlined in #12320, taking the median of each run I saw all 4 saw performance improvements (although for a small number of wheels it was small enough to be negligible):
requests
pandas[performance,excel,html,parquet]
apache-airflow[all]
homeassistant
from #12320