Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] add dataloader for lance datasource #49459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jay-ju
Copy link
Contributor

@Jay-ju Jay-ju commented Dec 27, 2024

Why are these changes needed?

The storage format of lance will be used in multimodal preprocessing and training. When used for training, it needs to be loaded by Dataloader. Here are two relatively important characteristics:

  1. lance supports point query and can be randomly shuffled.
  2. After lance is adapted to dataloader, it can load data in a streaming manner to prevent memory overflow and excessive loading time of training data.

Therefore, this provides how lance can form a Dataset for torch Dataloader implementation, enabling the unification of ray train and ray data.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Jay-ju Jay-ju requested a review from a team as a code owner December 27, 2024 09:06
@jcotant1 jcotant1 added the data Ray Data-related issues label Dec 27, 2024
@Jay-ju Jay-ju force-pushed the add_lance_dataloader branch 2 times, most recently from db645c4 to 633407f Compare December 30, 2024 03:13
@Jay-ju Jay-ju force-pushed the add_lance_dataloader branch from 633407f to 47fe1b1 Compare December 30, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Ray Data-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants