[core] Use ActorState_Name
to print ActorState
#49483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ray/src/ray/protobuf/gcs.proto
Lines 78 to 90 in 8c2d945
ActorState
is an enum defined in Protobuf. IfActorState_Name
is not called, an integer will be printed instead. For example,rpc::ActorTableData::DEAD
would print as 4.Without this PR: "with status 4"
With this PR: "with status DEAD"
I also considered implementing
std::ostream &operator<<(std::ostream &out, ...)
. However, there are several issues:ActorState
can be printed directly without causing compilation errors, making it difficult to determine whether the overloaded operator is being called.ActorState
does not necessarily#include
the utility functionoperator<<
.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.