-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Remove unused runtime env callback #49485
base: master
Are you sure you want to change the base?
[core] Remove unused runtime env callback #49485
Conversation
Signed-off-by: dentiny <[email protected]>
b8034c8
to
db7869c
Compare
cpp tests build failure [2024-12-29T12:19:12Z] //:gcs_actor_manager_export_event_test FAILED TO BUILD do we actually use those callbacks in unit tests? |
Signed-off-by: dentiny <[email protected]>
No, they're unused; I should fix the compilation in the latest commit. |
|
I still think this PR is a no-op change, let me merge and run again... |
Consistent test failure so it might be due to this PR. |
I don't see the callback within
Deleter
used anywhere.