Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe .select() API needs some way to error on missing columns #8463

Open
jleibs opened this issue Dec 13, 2024 · 1 comment
Open

Dataframe .select() API needs some way to error on missing columns #8463

jleibs opened this issue Dec 13, 2024 · 1 comment
Labels
feat-dataframe-api Everything related to the dataframe API

Comments

@jleibs
Copy link
Member

jleibs commented Dec 13, 2024

When we select a column from the dataframe view, we previously made the decision that a missing column would provide results but be implicitly null.

The rationale for this decision was that in many situations, Rerun data producers may not even create a column if something is missing. For example: maybe a detector simply never logs anything if nothing is detected. In these cases, a query-writer reasonably wants a null column to exist.

However, the far, far far more common case is someone exploring the data and writing a test script made a typo. If a user doesn't actually know what was in the dataset, they may think this is validly null data, as opposed to realizing they aren't querying the right content.

We should instead default to error on null, and then provide a mechanism for advanced users to inject any missing-but-required columns into the view only in situations where it makes sense to do so.

@jleibs jleibs added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working feat-dataframe-api Everything related to the dataframe API and removed 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels Dec 13, 2024
@jleibs
Copy link
Member Author

jleibs commented Dec 13, 2024

Related: #7759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-dataframe-api Everything related to the dataframe API
Projects
None yet
Development

No branches or pull requests

1 participant