Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the entity path filter mutation API #8518

Open
abey79 opened this issue Dec 17, 2024 · 0 comments
Open

Improve the entity path filter mutation API #8518

abey79 opened this issue Dec 17, 2024 · 0 comments
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself

Comments

@abey79
Copy link
Member

abey79 commented Dec 17, 2024

Currently, all methods mutating the entity path filter in a ViewContents write the mutated filter to the blueprint store but leaves the deserialised version unchanged. This means that all mutations are lost except the last one within a frame, which is a major foot-gun. We should fix this API such as to allow arbitrary number of mutations during a frame (while retaining interior mutability for the ViewportBlueprint structure and friends).

@abey79 abey79 added 📺 re_viewer affects re_viewer itself 😤 annoying Something in the UI / SDK is annoying to use labels Dec 17, 2024
abey79 added a commit that referenced this issue Dec 18, 2024
### Related

* Related to #8518
* Related to #8431

### What

Fix a bug in #8431 where multi-entity drag-and-drop would only add a
single entity due to a foot-gun in our entity path filter mutation API
(see #8518 for more). Also add a new checklist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

1 participant