Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate dependency upgrade (inference-cli uses old version of rich library) #865

Open
1 of 2 tasks
samliu opened this issue Dec 6, 2024 · 3 comments
Open
1 of 2 tasks
Labels
bug Something isn't working

Comments

@samliu
Copy link

samliu commented Dec 6, 2024

Search before asking

  • I have searched the Inference issues and found no similar bug report.

Bug

https://github.com/roboflow/inference/blob/main/requirements/requirements.cli.txt

Requires rich~=13.0.0, but popular library instructor (and others) require newer version of rich (13.9.4 is latest).

Can someone look into whether this dependency version is truly necessary or can we bump the version number?

Environment

I'm on MacOS, M2, using pip.

python -m pip check
inference-cli 0.29.2 has requirement rich~=13.0.0, but you have rich 13.9.4.

Minimal Reproducible Example

pip install inference-cli --upgrade
pip install instructor --upgrade
python -m pip check

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@samliu samliu added the bug Something isn't working label Dec 6, 2024
@samliu samliu changed the title inference-cli conflicts with instructor because of rich dependency version investigate dependency upgrade (inference-cli uses old version of rich library) Dec 6, 2024
@PawelPeczek-Roboflow
Copy link
Collaborator

hi there, thanks for pointing this out - I do not see any problem with bumping the dependency - let me check if CI does not object

@PawelPeczek-Roboflow
Copy link
Collaborator

#867

@PawelPeczek-Roboflow
Copy link
Collaborator

change has been released. Could u please check on your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants