Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search issues #186

Open
6 of 9 tasks
nrc opened this issue Mar 7, 2018 · 0 comments
Open
6 of 9 tasks

Search issues #186

nrc opened this issue Mar 7, 2018 · 0 comments
Labels
L-js mostly a JS (or web) issue L-rust mostly a Rust (or backend) issue
Milestone
1.0

Comments

@nrc
Copy link
Member

nrc commented Mar 7, 2018 •
edited
Loading

Bugs

  • when you click a link from the search, it removes the search, the search should persist
  • formatting of search results is bad - doesn't fit the side panel well, links are not visible, etc.
  • changing tab clears the search box
  • buggy underlining and highlighting behaviour (depends on how a search was done and on previous searches

Features
@nrc nrc added this to the beta milestone Apr 4, 2018
nrc added a commit that referenced this issue Apr 12, 2018
@nrc
Fix a bug with needle highlighting
5414a0f 
cc #186
@nrc nrc modified the milestones: beta, 1.0 Apr 13, 2018
nrc added a commit that referenced this issue Apr 13, 2018
@nrc
Preserve the value in the search box on tab changes
2d43bf6 
Also sets the value on searches from the source view

cc #186
@nrc nrc added L-js mostly a JS (or web) issue L-rust mostly a Rust (or backend) issue labels May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L-js mostly a JS (or web) issue L-rust mostly a Rust (or backend) issue
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@nrc