Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List coauthors in merge commit #1

Open
mkoeppe opened this issue Feb 18, 2023 · 4 comments
Open

List coauthors in merge commit #1

mkoeppe opened this issue Feb 18, 2023 · 4 comments
Assignees

Comments

@tobiasdiez
Copy link

tobiasdiez commented Feb 19, 2023

The default format of the merge commit via the github api is also <pr title> (<pr number>). I propose to stick with gh defaults and to use this format.
The url and PR author seems to be unnecessary now as well. Instead of PR author I would say its more important that coauthors are properly added using Co-authored-by https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors.

@vbraun
Copy link
Member

vbraun commented Feb 20, 2023

For extracting the co-authors we also could try to parse them out of the git history. Setting the Co-authored-by correctly is quite annoying and many will not get it right.

@vbraun
Copy link
Member

vbraun commented Feb 25, 2023

I've changed it to gh-NUMBER

Renaming this issue to focus on coauthors

@vbraun vbraun changed the title Format gh-pr-NUMBER is not recognized by GitHub List coauthors in merge commit Feb 25, 2023
@tobiasdiez
Copy link

It might be that #2 fixes this issue as well. At least if you merge using github's ui, it properly adds the coauthors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants