Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead links in Architecture > Style #32

Open
atouchet opened this issue Feb 26, 2018 · 7 comments · Fixed by servo/servo#30960
Open

Dead links in Architecture > Style #32

atouchet opened this issue Feb 26, 2018 · 7 comments · Fixed by servo/servo#30960

Comments

@atouchet
Copy link

https://github.com/servo/servo/blob/master/docs/components/style.md

These links no longer work:

http://doc.servo.org/style/selector_parser/trait.SelectorImplExt.html
http://doc.servo.org/style/servo_selector_parser/struct.SelectorImpl.html
http://doc.servo.org/selectors/matching/struct.Rule.html
http://doc.servo.org/selectors/matching/struct.SelectorMap.html
http://doc.servo.org/style/stylist/struct.PerPseudoElementSelectorMap.html
http://doc.servo.org/style/stylist/struct.PerOriginSelectorMap.html
http://doc.servo.org/style/selector_parser/enum.PseudoElement.html
@gootorov
Copy link

@highfive assign me.

@highfive
Copy link

Hey @gootorov! Thanks for your interest in working on this issue. It's now assigned to you!

@gootorov gootorov mentioned this issue Mar 12, 2018
Merged
2 tasks
@gootorov
Copy link

Remaining dead links:
http://doc.servo.org/style/selector_parser/trait.SelectorImplExt.html
http://doc.servo.org/style/stylist/struct.PerOriginSelectorMap.html
http://doc.servo.org/style/selector_parser/enum.PseudoElement.html

bors-servo referenced this issue in servo/servo Mar 13, 2018
Auto merge of #20282 - gootorov:fix-stylemd-links, r=emilio
d78478f 
style: Fix some dead links in style.md

<!-- Please describe your changes on the following line: -->
Part of https://github.com/servo/servo/issues/20126

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] These changes do not require tests because: documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20282)
<!-- Reviewable:end -->
moz-v2v-gh referenced this issue in mozilla/gecko-dev Mar 13, 2018
@gootorov
servo: Merge #20282 - style: Fix some dead links in style.md (from go…
15fe722 
…otorov:fix-stylemd-links); r=emilio

<!-- Please describe your changes on the following line: -->
Part of https://github.com/servo/servo/issues/20126

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] These changes do not require tests because: documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d78478f9bda8a9706684e01101f40a8ff718fedd

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e441d2b22e80e6dfb0706f94d399483f4c597400
gecko-dev-updater referenced this issue in marco-c/gecko-dev-wordified-and-comments-removed Oct 2, 2019
@marco-c
servo: Merge #20282 - style: Fix some dead links in style.md (from go…
d3fb535 
…otorov:fix-stylemd-links); r=emilio

<!-- Please describe your changes on the following line: -->
Part of https://github.com/servo/servo/issues/20126

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] These changes do not require tests because: documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d78478f9bda8a9706684e01101f40a8ff718fedd

UltraBlame original commit: 3429fca91c54e41c032c97bd8ed4449be308d21c
gecko-dev-updater referenced this issue in marco-c/gecko-dev-comments-removed Oct 2, 2019
@marco-c
servo: Merge #20282 - style: Fix some dead links in style.md (from go…
f8022de 
…otorov:fix-stylemd-links); r=emilio

<!-- Please describe your changes on the following line: -->
Part of https://github.com/servo/servo/issues/20126

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] These changes do not require tests because: documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d78478f9bda8a9706684e01101f40a8ff718fedd

UltraBlame original commit: 3429fca91c54e41c032c97bd8ed4449be308d21c
gecko-dev-updater referenced this issue in marco-c/gecko-dev-wordified Oct 2, 2019
@marco-c
servo: Merge #20282 - style: Fix some dead links in style.md (from go…
660d1ab 
…otorov:fix-stylemd-links); r=emilio

<!-- Please describe your changes on the following line: -->
Part of https://github.com/servo/servo/issues/20126

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] These changes do not require tests because: documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d78478f9bda8a9706684e01101f40a8ff718fedd

UltraBlame original commit: 3429fca91c54e41c032c97bd8ed4449be308d21c
@sculpt0r
Copy link

Is this issue still free to take? I found at least one link that confuses me: https://github.com/servo/servo/blob/main/docs/components/style.md?plain=1#L134

When you enter the website, it redirects you to the URL without any path and there seems to be some not related content at the top of it 🤔

@atouchet
Copy link
Author

I'm assuming the domain was allowed to expire and was then registered by someone else for hosting spam. I'm not sure if that link should be changed to something else or just removed entirely.

@sculpt0r sculpt0r mentioned this issue Dec 30, 2023
Merged
5 tasks
@sculpt0r
Copy link

image

Seems like someone unauthorised gains access....

Anyway, it looks like the Stylo has a new name: Quantum/Style which leads to Quantum itself.

If thats ok, I created a small PR for that: servo/servo#30960

@atouchet
Copy link
Author

Stylo was a component of the overall Quantum project. I don't think that text needs to be changed.

@atouchet atouchet reopened this Jan 3, 2024
@mrobinson mrobinson transferred this issue from servo/servo Nov 1, 2024
@mrobinson mrobinson changed the title Dead links in style.md Dead links in Architecture > Style Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(style): update outdated stylo project name and link sculpt0r/servo
4 participants
@highfive @sculpt0r @gootorov @atouchet