Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locations: Add field company in location parameters #15971

Open
marcinBB8 opened this issue Dec 16, 2024 · 11 comments
Open

Locations: Add field company in location parameters #15971

marcinBB8 opened this issue Dec 16, 2024 · 11 comments

Comments

@marcinBB8
Copy link

It would be useful to add field [Company] in locations.
Naw in [Custom Asset Report] any user can view all locations even from other companies witch is not wanted issue.

@swift2512
Copy link

You probably generated this report with super user account because I can't reproduce that on latest git pull with admin account - company part is greyed out, exported data doesn't contain anything from other companies.
image
Assets assigned for particular location (seen by SUPER USER vs. ADMIN)
image

@marcinBB8
Copy link
Author

marcinBB8 commented Dec 16, 2024

Sorry maby i too shortly described the issue.

We decided to name locations like pattern: CompanyName_Place
So we have:
Company1_CentralOffice
Company1_Warsaw
Company1_Bielsko

Company2_CentralOffice
Company2_Bielsko
Company2_Wroclaw

Naw when i logedin as one of user Company1 thats true the /company/ field in [Custom Asset Report] is greyed out and generated report is empty when chose location from Company2, but main issue is that in field /location/ or /default location/ dropdawn menu is showing up for him these locations names from other companies. It can generate problem that noone should know witch other comanies we are supporting and these way every user will know that.

These is why i can't share screenshot to show you exact problem.

@Godmartinz
Copy link
Collaborator

It seems like you use locations in a way that would function like departments. I dont know how you have things set up, but using departments like this in the image below would give you the multi-company seperation you are looking for I believe.
image

@marcinBB8
Copy link
Author

marcinBB8 commented Dec 16, 2024

Locations is physical structure of Company.
Departments is logical structure of it.

Departments are e.g. IT, management, service, sales
Locations are just locations as I previously shown

There can be IT department in Company1_CentralOffice and in Company1_Bielsko and these is the same department.
So Location and Department should be separate property,not depended (not parent-child)

@swift2512
Copy link

It seems like you use locations in a way that would function like departments. I dont know how you have things set up, but using departments like this in the image below would give you the multi-company seperation you are looking for I believe. image

Department can only have 1 location assigned to it and departments are visible by everyone in that company with 'View departments' permission. If you are part of a company, have permissions to view departments/locations, you can pull everything from database. Or am I missing something?

The only real way to isolate users is to enable multi-company support and give super user permission to admins. This way admins can see everyone, but everyone else is limited to their company.

@swift2512
Copy link

@marcinBB8 unfortunately, location hierarchy doesn't do anything in SnipeIT.
Tomorrow, at work, I'll check if departments do anything other than being just another filter.

@swift2512
Copy link

swift2512 commented Dec 17, 2024

As I wrote yesterday, departments doesn't isolate anything. It's just a filter for people in the database. I have regular users with permissions to view/edit departments and they get complete list of departments in the company they are assigned to.

In SnipeIT you can't limit you agents (admins) by location or anything else, just by COMPANY. Person can be assigned only to a single company. Only SUPER USERS can see assets, people, departments, etc. from all companies in the database, but probably nobody wants to grant full access to a guy, who is doing checkins/checkouts of items.

@marcinBB8
Copy link
Author

marcinBB8 commented Dec 17, 2024

I think you don't understood the problem.

ok user cant modify or view assets from other company, but those who are allowed to reports can view locations and know other companies that we are supporting.

@swift2512
Copy link

I think you don't understood the problem.

ok user cant modify or view assets from other company, but those who are allowed to reports can view locations and know other companies that we are supporting.

It's you who doesn't understand what you're being told. :) Read documentation, install a test copy on virtual machine and play with it to understand how Snipe-IT works.
I will repeat myself - the only way to isolate COMPANY A (it's people, assets, departments, but not locations) from COMPANY B (C, D, E, etc.) is to enable Multi-Company support and create different companies via 'Settings > Companies'.

You can name your 'locations' whatever you want, you can image that those are different companies, but user who has permission 'View locations' will see all locations that are created in Snipe-IT. Don't ask me why Snipe-IT locations aren't attached to companies - I'm just user who's working with Snipe-IT for 3+ years. Also, Snipe-IT doesn't have location based permission system.

You can't use 'departments' as companies for the same reason - user with permission 'View departments' will see all departments created in Snipe-IT if 'Multi-Company Support' is not enabled.

p.s.
I am waiting for location based permissions since forever. Snipe-IT already has location tree (but lacks a way to display it), next step would be to attach locations to companies and limit user's view to the parent location (and it's children) they are assigned. @snipe why not add it to a roadmap? :)

@marcinBB8
Copy link
Author

marcinBB8 commented Dec 17, 2024

I understand how Snipe work in current state, I just suggested what is wrong in Snipe and what is good to change in next update.

We have enabled "full multi-company support" of course.

for me it is obvious that location should be assigned to company and have no idea how it happened that these basic parameter wasn't designed at project stage of creating Snipe database structure

@swift2512
Copy link

I understand how Snipe work naw. and I just suggested what is wrong in Snipe and what is good to change in next update.

We have enabled "full multi-company support" of course.

for me it is obvious that location should be assigned to company and have no idea how it happened that these basic parameter wasn't designed at project stage of creating Snipe database structure
I'm using Snipe-IT since v4.8.0 and pretty sure that 'locations' logic didn't change since then. There's a PR for this, but it's 'work in progress' since 2023. Hopefully it will be merged and will make life easier for everyone working with Snipe-IT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants