Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash autocompletion #53

Open
kerscher opened this issue Apr 6, 2018 · 5 comments
Open

Bash autocompletion #53

kerscher opened this issue Apr 6, 2018 · 5 comments

Comments

@kerscher
Copy link

kerscher commented Apr 6, 2018

For interactive users, it would be useful to provide shell completion.
GNU Bash is widespread and a good candidate for first implementation.

I can help by providing a PR, but would need to know if this is useful to spend time on or not.
If so I’ll sign the CLA and send the request.

@csstaub
Copy link
Contributor

csstaub commented Apr 6, 2018

Yeah, that'd nice. We could get it for free if we migrate to using kingpin for flags, I think.

@kerscher
Copy link
Author

Would the bash_profile version where you have to eval $(certstrap --completion-script-bash) be acceptable? This avoids having to change any installation routines and affecting the user global state.

Reference: https://github.com/alecthomas/kingpin#bashzsh-shell-completion

@kerscher
Copy link
Author

Migrating to kingpin seems like a medium-size change and not a simple addition of a bash script. Is this in the roadmap, just a general idea, or something one could possibly work in parallel and merge afterwards?

@mcpherrinm
Copy link
Contributor

I think migrating to kingpin is on our immediate short-term roadmap -- I was hoping to do it sometime this month. And then we get it for free.

All our other go command line tools use it, so it would make maintenance easier for us.

@mweissbacher
Copy link
Contributor

I looked into this and the single dash multiple character flags ( -help vs --help ) are not supported in kingpin and would break backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants