Command menu refactoring #9257
Merged
Command menu refactoring #9257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements automatic first item selection in the command menu to improve keyboard navigation efficiency.
- Added
setSelectedItemIdfunction inuseSelectableList.tsto manage item selection state - Introduced
selectFirstItemboolean prop inSelectableList.tsxwith default false value - Modified
CommandMenu.tsxto enable first item selection viaselectFirstItem={true} - Implemented selection reset logic before setting new selections to prevent state conflicts
- Added proper state management for selected items using Recoil selectors and atoms
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/ui/layout/selectable-list/hooks/useSelectableList.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/selectable-list/hooks/useSelectableList.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/selectable-list/components/SelectableList.tsx
Outdated
Show resolved
Hide resolved
thomtrp
reviewed
Dec 27, 2024
packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsx
Outdated
Show resolved
Hide resolved
bosiraphael
changed the title
thomtrp
approved these changes
Dec 30, 2024
bosiraphael
deleted the
9251-the-first-item-of-the-command-menu-should-be-focused-on-open
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
CommandMenucomponent to make it more readable and easier to refactor.The file was way too big so I introduced a few hooks and eliminated code duplication.
Introduced:
useMatchCommandshook to match commands with the searchuseCommandMenuCommandswhich returns all command menu commandsuseMatchingCommandMenuCommandsto return the commands matched with the searchCommandMenuContainerto simplify theDefaultLayoutUnmounted the
CommandMenuwhen it wasn't opened to improve performancesI also introduced a new behavior: Automatically select the first item when opening the command menu:
https://github.com/user-attachments/assets/4b683d49-570e-47c9-8939-99f42ed8691c