Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust linker directives #1504

Open
5 tasks
jeromelaban opened this issue Nov 21, 2024 · 1 comment
Open
5 tasks

Adjust linker directives #1504

jeromelaban opened this issue Nov 21, 2024 · 1 comment
Assignees
Labels
kind/bug Something isn't working

Comments

@jeromelaban
Copy link
Member

Current behavior

An app using themes may fail to run if the linker settings are not setup properly.

How to reproduce it (as minimally and precisely as possible)

Run a sample app with material included, build in release on iOS for a physical device.

Workaround

In the linker settings file:

<assembly fullname="Uno.Material.WinUI" />
<assembly fullname="Uno.Themes.WinUI" />
<assembly fullname="Uno.Toolkit.WinUI.Material" />

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • UWP
  • MacOS

Anything else we need to know?

@jeromelaban jeromelaban added the kind/bug Something isn't working label Nov 21, 2024
@kazo0 kazo0 self-assigned this Nov 21, 2024
@kazo0
Copy link
Collaborator

kazo0 commented Dec 5, 2024

I am currently unable to reproduce the issue reported by the client. I have tried using the linker as aggressively as possible and the Material styles are still present in my test app.

Without being able to reproduce the issue, it is going to be difficult to know which parts of the Material/Toolkit code needs to be made linker safe.

As it stands now, we have a LinkerConfig.xml inside of Toolkit and Material. Although this would prevent linker errors, the side-effect is that you will always be including the entire assembly in your app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants