-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a check that validates Gtk 3 installation on Windows #94
Closed
aesteves900
wants to merge
2
commits into
unoplatform:main
from
aesteves900:dev/AEST/12-add-validation-gtk3-windows
Closed
feat: Add a check that validates Gtk 3 installation on Windows #94
aesteves900
wants to merge
2
commits into
unoplatform:main
from
aesteves900:dev/AEST/12-add-validation-gtk3-windows
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteves900
force-pushed
the
dev/AEST/12-add-validation-gtk3-windows
branch
from
September 7, 2022 02:48
a794b2f
to
15be4e7
Compare
jeromelaban
reviewed
Sep 7, 2022
jeromelaban
reviewed
Sep 7, 2022
jeromelaban
reviewed
Sep 7, 2022
aesteves900
force-pushed
the
dev/AEST/12-add-validation-gtk3-windows
branch
4 times, most recently
from
September 7, 2022 21:11
6912621
to
1aa1a2c
Compare
jeromelaban
reviewed
Sep 12, 2022
aesteves900
force-pushed
the
dev/AEST/12-add-validation-gtk3-windows
branch
from
September 13, 2022 04:24
1aa1a2c
to
8d79940
Compare
jeromelaban
reviewed
Sep 13, 2022
aesteves900
force-pushed
the
dev/AEST/12-add-validation-gtk3-windows
branch
3 times, most recently
from
September 14, 2022 01:36
29615a4
to
3ae3c7a
Compare
ebariche
reviewed
Sep 14, 2022
ebariche
reviewed
Sep 14, 2022
aesteves900
force-pushed
the
dev/AEST/12-add-validation-gtk3-windows
branch
2 times, most recently
from
September 17, 2022 22:45
43b48e5
to
f92ca0f
Compare
feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows feat: Add a check that validates Gtk 3 installation on Windows
jeromelaban
force-pushed
the
dev/AEST/12-add-validation-gtk3-windows
branch
from
October 18, 2022 12:56
f92ca0f
to
c700e89
Compare
Deprecated feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #12
PR Type
What kind of change does this PR introduce?
What is the current behavior?
People from the community have reported that certain projects fail to build because of long paths.
There is no check for GTK3 activation on Windows.
What is the new behavior?
The uno-check will validate the presence of GTK3+ and install if required.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information