Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WorkingWithRecords.md #2586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JohannesMP
Copy link

@JohannesMP JohannesMP commented Oct 12, 2024

Message record status property is declared as lowercase in primary constructor (line 98), but is uppercase when used in example code (line 109)

Message field 'status' is declared lowercase, but was used uppercase.
@ajpinedam
Copy link
Contributor

Thank you @JohannesMP for your contribution!

@ajpinedam
Copy link
Contributor

@JohannesMP, could you please correct the commit message so it matches the convention? https://www.conventionalcommits.org/en/v1.0.0/

Since this is a documentation change, all you need is to add docs: at the beginning, something like:

docs: Update WorkingWithRecords.md

@@ -106,7 +106,7 @@ In our Model:
message = message with
{
Content = response.Message,
Status = response.IsError ? Status.Error : Status.Value
status = response.IsError ? Status.Error : Status.Value
Copy link
Contributor

@kazo0 kazo0 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best instead to alter the property declarations here:

public partial record Message(string Content, Status status, Source source);

And change it to properly capitalize each of those public properties on the record. So it should be

public partial record Message(string Content, Status Status, Source Source);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants