Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI app title is "WinUI Desktop" #368

Open
10 tasks
MartinZikmund opened this issue Oct 29, 2023 · 2 comments
Open
10 tasks

WinUI app title is "WinUI Desktop" #368

MartinZikmund opened this issue Oct 29, 2023 · 2 comments
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@MartinZikmund
Copy link
Member

Current behavior

The generated apps have "WinUI Desktop" in the title bar.

Expected behavior

It would be better to use the actual project name - which is what other platforms are doing AFAIK

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@MartinZikmund MartinZikmund added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Oct 29, 2023
@MartinZikmund MartinZikmund changed the title Default app title is "WinUI Desktop" WinUI app title is "WinUI Desktop" Oct 29, 2023
@dansiegel
Copy link
Contributor

Is there perhaps a way we could solve this from Uno.WinUI through some combination of

  • Build Targets
  • Source Gen
  • Uno.UI.Toolkit

Solving this specifically in the Template we would have several code paths to consider...

  • Are we using Extensions
  • Are we using just a blank template
  • Naturally we want to avoid any new code if the template is generated without the WinUI head...

cc: @jeromelaban

@nickrandolph
Copy link
Contributor

For icons, we added support to Resizetizer. Perhaps we can do something similar since this value can come from the package manifest file (same as for icon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

No branches or pull requests

3 participants