Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AppBarButton inside NavigationBar keeps rendering on every click #1302

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Dec 9, 2024

GitHub Issue (If applicable): closes unoplatform/uno#18506

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

In Fluent theme, clicking on an AppBarButton inside a NavigationBar with any kind of Icon set makes it unresponsive. The Click event never fires because the AppBarButton's Icon is rendered at every click, since the Color is changing opacity.

What is the new behavior?

AppBarButton click works in both Fluent and Material theme.

PR Checklist

Please check if your PR fulfills the following requirements:

@rajamatt rajamatt self-assigned this Dec 9, 2024
@rajamatt rajamatt force-pushed the dev/mara/fix-appbarbutton-navbar branch from 5183f43 to 0bccb63 Compare December 9, 2024 16:27
@rajamatt rajamatt marked this pull request as ready for review December 9, 2024 16:27
@rajamatt rajamatt requested a review from kazo0 December 9, 2024 16:27
@rajamatt rajamatt changed the title fix: fix: AppBarButton inside NavigationBar keeps rendering on every click Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1302.eastus2.azurestaticapps.net

2 similar comments
Copy link

github-actions bot commented Dec 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1302.eastus2.azurestaticapps.net

Copy link

github-actions bot commented Dec 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1302.eastus2.azurestaticapps.net

@rajamatt rajamatt enabled auto-merge December 10, 2024 00:38
@rajamatt rajamatt merged commit c84aa79 into main Dec 10, 2024
28 checks passed
@rajamatt rajamatt deleted the dev/mara/fix-appbarbutton-navbar branch December 10, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] NavigationBar PrimaryCommands unresponsive
2 participants