Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Transparent icon background on non-mobile #17855

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: Transparent icon background on non-mobile #17855

wants to merge 2 commits into from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Aug 6, 2024 •
edited
Loading

Requires unoplatform/uno.resizetizer#310

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Icon background file is used by default on WinUI, Desktop and WASM

What is the new behavior?

Not used by default

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@MartinZikmund MartinZikmund changed the title feat: Do not apply icon background on desktop, WinUI, and WASM by def… feat: Transparent icon background Aug 6, 2024
@MartinZikmund MartinZikmund changed the title feat: Transparent icon background feat: Transparent icon background on non-mobile Aug 6, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17855/index.html

@MartinZikmund MartinZikmund mentioned this pull request Aug 6, 2024
Open
7 tasks
@morning4coffe-dev
Copy link
Member

I need those changes, very nice! 🚀

@nventive-devops
Copy link
Contributor

The build 135420 found UI Test snapshots differences: android-28-net8: 829, android-28-net8-Snap: 1065, ios: 268, ios-Snap: 1056, skia-gtk-screenshots: 2214, skia-linux-screenshots: 2214, skia-windows-screenshots: 2214, wasm: 514, wasm-automated-net8.0-UWP-Default-automated: 1951, wasm-automated-net8.0-UWP-RuntimeTests-0: 1, wasm-automated-net8.0-UWP-RuntimeTests-1: 1, wasm-automated-net8.0-UWP-RuntimeTests-2: 1, wasm-automated-net8.0-WinUI-Benchmarks-automated: 1, wasm-automated-net8.0-WinUI-RuntimeTests-0: 1, wasm-automated-net8.0-WinUI-RuntimeTests-1: 1, wasm-automated-net8.0-WinUI-RuntimeTests-2: 1

Details

  • android-28-net8: 829 changed over 839

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Affect_Measurement_polygon_PolygonPage_-_ChangeShape-After_clear
    • Affect_Measurement_polygon_SamplesApp_Windows_UI_Xaml_Shapes_PolygonPage
    • BasicNavigationView_SamplesApp_Samples_Windows_UI_Xaml_Controls_NavigationViewTests_NavigationView_Pane_Automated
    • BasicExpressionTest_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_ExpressionTest
    • BasicTest_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage
    • BitmapSource_PixelSize_ImageSource_PixelSize_-_Result
    • Border_AntiAlias_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderAntiAlias
    • Button_Events_UITests_Shared_Windows_UI_Xaml_Controls_Button_Button_Events
    • Button_OverlappedButtons_UITests_Shared_Windows_UI_Xaml_Controls_Button_Overlapped_Buttons
    • CheckBox_DoubleTapValidation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
    • Check_CornerRadius_Border_No_CornerRadius
    • Change_Manipulation_Property_Before_property_change
    • Button_IsOpacity_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_Opacity_Automated
    • Check_Bound_Color_Complete
    • Change_Manipulation_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
    • CheckBox_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
    • ComboBoxTests_Stretch_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Stretch
    • ComboBoxTests_VisibleBounds_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_VisibleBounds
    • ComboBoxTests_ToggleDisabled_ComboBox_Disabled
    • ClosedPath_SamplesApp_Windows_UI_Xaml_Media_Geometry_ClosedFigurePage

  • android-28-net8-Snap: 1065 changed over 1065

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimation_BeginTime_Uno_UI_Samples_Content_UITests_Animations_DoubleAnimation_BeginTime
    • Animations_UITests_Shared_Windows_UI_Xaml_Media_Animation_SetTargetProperty_UITests_Shared_Windows_UI_Xaml_Media_Animation_SetTargetProperty
    • AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion
    • Border_BorderBottomwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderBottomwithmargins
    • Border_Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThickness
    • Border_OnepxThicknessandRadiusAndTextBlock_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadiusAndTextBlock
    • Border_UniformThicknessandNonUniformRadius_Uno_UI_Samples_UITests_BorderTestsControl_UniformThicknessandNonUniformRadius
    • Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset
    • Brushes_UITests_Windows_UI_Xaml_Media_AcrylicBrushTests_BasicAcrylicBrushTest_UITests_Windows_UI_Xaml_Media_AcrylicBrushTests_BasicAcrylicBrushTest
    • Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_Brushes_ImplicitConvert_UITests_Windows_UI_Xaml_Media_BrushesTests_Brushes_ImplicitConvert
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY2
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource
    • CheckBox_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_Automated_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_Automated
    • CheckBox_UITests_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_States_UITests_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_States
    • ComboBox_ComboBox_ItemsSource_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ItemsSource
    • ComboBox_ComboBox_Legacy_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Legacy
    • CommandBar_CommandBar_BackButtonImage_UITests_Windows_UI_Xaml_Controls_CommandBar_BackButtonImage_CommandBar_Frame
    • CommandBar_CommandBar_BackButtonTitle_UITests_Windows_UI_Xaml_Controls_CommandBar_BackButtonTitle_CommandBar_Frame
    • ContentControl_ContentControl_WithInlineContent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_WithInlineContent
    • ContentControl_ContentControl_WithPadding_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_WithPadding

  • ios: 268 changed over 268

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BitmapSource_PixelSize_ImageSource_PixelSize_-_Result
    • Button_NestedButtons_Validation_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Nested_Buttons
    • Change_Manipulation_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
    • Check_CornerRadius_Border_No_CornerRadius
    • ContentControl_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Changing_ContentTemplate
    • FocusManager_FocusDirection_Up_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
    • Image_Source_Nullify_image_source_nullify_cleared
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Test_NoScrollViewer_Automated
    • ListView_ObservableCollection_Creation_Count_Added
    • ListView_ObservableCollection_Creation_Count_Added_above
    • RadioButton_DoubleTap_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_RadioButton_IsEnabled_Automated
    • RadioButton_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_RadioButton_IsEnabled_Automated
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-2
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-3
    • Screenshots_Image_Stretch_Alignment_Wider_Mode-0
    • Screenshots_Image_Stretch_Alignment_Wider_Mode-1
    • TextBox_AutoGrow_Horizontally_Test_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Multiline_AutoHeight
    • TextBox_AutoGrow_Vertically_Test_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Multiline_AutoHeight
    • TextBox_MaxLength_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_MaxLength

  • ios-Snap: 1056 changed over 1056

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimation_Opacity_TextBlock_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_Opacity_TextBlock
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill
    • AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion
    • Border_BorderBottomwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderBottomwithmargins
    • Border_Border_CornerRadius_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius
    • Border_Simple_with_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Simple_with_Radius
    • Brushes_EllipsemaskingEllipseSuperpositionPanel_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseSuperpositionPanel
    • Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
    • Brushes_Rectangle_Uno_UI_Samples_UITests_ImageBrushTestControl_Rectangle
    • Brushes_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay
    • Buttons_AppBarToggleButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarToggleButtonTest
    • Buttons_AppBar_KeyBoard_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBar_KeyBoard
    • Buttons_Overlapped_Buttons_UITests_Shared_Windows_UI_Xaml_Controls_Button_Overlapped_Buttons
    • Buttons_RadioButton_Combined_Style_UITests_Shared_Windows_UI_Xaml_Controls_Button_RadioButton_Combined_Style
    • ComboBox_ComboBox_Corners_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Corners
    • ComboBox_ComboBox_Disabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Disabled
    • ComboBox_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Description_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Description
    • CommandBar_CommandBar_BackButtonImage_UITests_Windows_UI_Xaml_Controls_CommandBar_BackButtonImage_CommandBar_Frame
    • ContentPresenter_ContentPresenter_LocalOverride_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_LocalOverride
    • ContentPresenter_ContentPresenter_Padding_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Padding

  • skia-gtk-screenshots: 2214 changed over 2216

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AppBarToggleButtonTest.png-dark
    • ApplicationViewSizing.png
    • AutoBorderStretchwithleftmargin.png
    • AutomationProperties_Name.png-dark
    • BackGesture.png-dark
    • Basics Pivot Test.png
    • BitmapIcon_Sizing.png-dark
    • Border_Simple_No_Background_With_Content_Border_With_Background.png-dark
    • Border_With_TranslateTransform.png
    • Brushes_ImplicitConvert.png-dark
    • ChatBox.png-dark
    • ChatBox.png
    • CommandBar_BackButtonImage.png-dark
    • CommandBar_BackButtonImage.png
    • ContentDialog_ComboBox.png
    • ContentDialog_Simple.png-dark
    • DoubleAnimation_RenderTransformOrigin.png-dark
    • DoubleAnimation_RenderTransformOrigin.png
    • Elevation.png
    • ElevationView_Clipping.png-dark

  • skia-linux-screenshots: 2214 changed over 2216

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Application_Window lifecycle events.png
    • AppWindowPresenters.png-dark
    • Attributed_text_FontSize_Changing.png-dark
    • AuthenticationBroker_Demo.png
    • AutoBorderStretchwithtopmargin.png-dark
    • AutoSizedPathCentered.png-dark
    • AutoSuggestBox_Description.png
    • AutoSuggestBox_Keyboard.png-dark
    • BasicAutoSuggestBox.png-dark
    • BasicAutoSuggestBox.png
    • Basics_Automated.png
    • BasicThemeResources.png-dark
    • BitmapIcon_Monochromatic.png-dark
    • BitmapIcon_Monochromatic.png
    • BorderRightwithmargins.png-dark
    • BorderRightwithmargins.png
    • Border_CornerRadius.png-dark
    • Border_CornerRadius.png
    • Border_CornerRadius_Toggle.png-dark
    • Border_CornerRadius_Toggle.png

  • skia-windows-screenshots: 2214 changed over 2216

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ApplicationViewMode.png
    • AppWindowPositionAndSize.png-dark
    • AppWindowPresenters.png-dark
    • Arrange_Performance01.png
    • Attributed_text_Supserscript.png
    • AutomationProperties_AutomationId.png
    • AutoSuggestBoxChosenSuggestion.png-dark
    • AutoSuggestBox_BitmapIcon.png
    • BackGesture.png-dark
    • BackGesture.png
    • BasicEnability.png-dark
    • BasicEnability.png
    • BenchmarkDotNet.png
    • BezierSegment.png-dark
    • BorderBottomwithmargins.png-dark
    • BorderBottomwithmargins.png
    • BorderRightwithmargins.png-dark
    • BorderRightwithmargins.png
    • Border_CornerRadius.png-dark
    • Border_CornerRadius.png

  • wasm: 514 changed over 1043

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • GenericApp.Views.Content.UITests.Animations.DoubleAnimationUsingKeyFrames_TranslateX
    • GenericApp.Views.Content.UITests.Animations.DoubleAnimation_TranslateX
    • GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode
    • MUXControlsTestApp.BreadcrumbBarPage
    • MUXControlsTestApp.NavigationViewItemTemplatePage
    • MUXControlsTestApp.RadialGradientBrushPage
    • SamplesApp.Samples.UnitTests.HttpUnitTests
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGrouped_ItemContainerStyleSelector
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewer
    • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathVerticalOffset
    • UITests.Lottie.LottieProgressPage
    • UITests.Microsoft_UI_Xaml_Controls.CommandBarTests.CommandBar_Primary_And_Secondary
    • UITests.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_ExecuteScriptAsync
    • UITests.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigationProperties
    • UITests.Microsoft_UI_Xaml_Controls.WebViewTests.WebView_InvokeScriptAsync
    • UITests.Shared.Windows_UI_Input.VisualStatesTests.TextBox_VisualStates
    • UITests.Shared.Windows_UI_StartScreen.JumpListTests
    • UITests.Shared.Windows_UI_Xaml_Controls.Canvas.Canvas_ZIndex
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ComboBoxItem_Selection
    • UITests.Shared.Windows_UI_Xaml_Controls.Popup.Popup_Overlay_On

  • wasm-automated-net8.0-UWP-Default-automated: 1951 changed over 1962

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Affect_Measurement_polygon_SamplesApp_Windows_UI_Xaml_Shapes_PolygonPage
    • Affect_Measurement_polyline_SamplesApp_Windows_UI_Xaml_Shapes_PolylinePage
    • Animations_DoubleAnimationUsingKeyFrames_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimationUsingKeyFrames_TranslateX
    • Animations_DoubleAnimation_opacity_final_state_UITests_Windows_UI_Xaml_Media_Animation_DoubleAnimation_FinalState_Opacity
    • Animations_DoubleAnimation_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_TranslateX
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage
    • AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion
    • BasicNavigationView_SamplesApp_Samples_Windows_UI_Xaml_Controls_NavigationViewTests_NavigationView_Pane_Automated
    • BezierSegment_SamplesApp_Windows_UI_Xaml_Media_Geometry_BezierSegment
    • BitmapImage_vs_SvgImageSource_BitmapLocal_UITests_Windows_UI_Xaml_Controls_ImageTests_BitmapImage_vs_SvgImageSource
    • BitmapImage_vs_SvgImageSource_SvgRemote_UITests_Windows_UI_Xaml_Controls_ImageTests_BitmapImage_vs_SvgImageSource
    • BitmapImage_vs_SvgImageSource_SvgRemote_url_direct
    • Border_Border_CornerRadius_Gradient_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Gradient
    • Border_Border_CornerRadius_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius
    • Border_LinearGradient_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_LinearGradientBrush
    • Border_NonUniformThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_NonUniformThicknessandRadius
    • Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle
    • Border_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderWithNullBrushAndNonZeroThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderWithNullBrushAndNonZeroThickness
    • Brushes_ImageBrushShapeStretchesAlignments_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrushShapeStretchesAlignments
    • Brushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2

  • wasm-automated-net8.0-UWP-RuntimeTests-0: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

  • wasm-automated-net8.0-UWP-RuntimeTests-1: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

  • wasm-automated-net8.0-UWP-RuntimeTests-2: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

  • wasm-automated-net8.0-WinUI-Benchmarks-automated: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunBenchmarks_Benchmarks_Shared_Controls_BenchmarkDotNetTestsPage

  • wasm-automated-net8.0-WinUI-RuntimeTests-0: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

  • wasm-automated-net8.0-WinUI-RuntimeTests-1: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

  • wasm-automated-net8.0-WinUI-RuntimeTests-2: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

@MartinZikmund
Copy link
Member Author

unoplatform/uno.resizetizer#310 needs to be merged first

@MartinZikmund MartinZikmund marked this pull request as draft August 27, 2024 11:40
@morning4coffe-dev morning4coffe-dev added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17855/index.html

@nventive-devops
Copy link
Contributor

The build 140297 found UI Test snapshots differences: android-28-net8: 30, android-28-net8-Snap: 61, ios: 7, ios-Snap: 58, skia-gtk-screenshots: 1832, skia-linux-screenshots: 1644, skia-windows-screenshots: 1502, wasm: 172, wasm-automated-net8.0-UWP-Default-automated: 52, wasm-automated-net8.0-UWP-RuntimeTests-0: 0, wasm-automated-net8.0-UWP-RuntimeTests-1: 1, wasm-automated-net8.0-UWP-RuntimeTests-2: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 30 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
    • CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_1_-_Initial_State
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ListViewItem_-_2_-_Click_outside
    • FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
    • PasswordShouldBeObscured_UITests_Shared_Windows_UI_Xaml_Controls_PasswordBoxTests_PasswordBoxPage
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_Basic_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_RightTappedTests
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Validate_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
    • WebView_NavigateToAnchor_Initial
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_2_-_Orientation_Landscape
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ListViewItem_-_1_-_Initial_State

  • android-28-net8-Snap: 61 changed over 1065

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_BorderRightwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderRightwithmargins
    • Icons_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic
    • Shapes_UITests_Windows_UI_Xaml_Shapes_PathStretchModes_UITests_Windows_UI_Xaml_Shapes_PathStretchModes
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • GridView_Uno_UI_Samples_Content_UITests_GridView_GridView_Inside_ScrollViewer_Uno_UI_Samples_Content_UITests_GridView_GridView_Inside_ScrollViewer
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Border_BorderLeftwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderLeftwithmargins
    • ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
    • Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
    • Buttons_Hyperlink_Button_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Hyperlink_Button
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • MUX_TwoPaneView_UITests_Shared_Microsoft_UI_Xaml_Controls_TwoPaneViewTests_TwoPaneViewPage
    • Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path
    • ListView_ListView_TransformsOnList_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_TransformsOnList
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal

  • ios: 7 changed over 267

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • ios-Snap: 58 changed over 1056

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Keyboard_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList
    • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
    • ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
    • Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
    • MUX_MUXControlsTestApp_DropDownButtonPage_MUXControlsTestApp_DropDownButtonPage
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
    • TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
    • NavigationView_MUXControlsTestApp_PaneLayoutTestPage_MUXControlsTestApp_PaneLayoutTestPage
    • NavigationView_NavigationViewSample_SamplesApp_Samples_NavigationViewSample_NavigationViewSample
    • NavigationView_NavigationView_BasicNavigation_SamplesApp_Samples_Windows_UI_Xaml_Controls_NavigationViewTests_NavigationView_BasicNavigation
    • Brushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageAlignment2541_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageAlignment2541
    • Grid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_Definitions
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats

  • skia-gtk-screenshots: 1832 changed over 2216

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AppBarButtonWithIconTest.png
    • ApplicationViewSpanningRectsPage.png-dark
    • Application_Window lifecycle events.png
    • Arrange_Performance01.png-dark
    • Attributed_text_Supserscript.png
    • AutoBorderStretchwithtopmargin.png
    • AutoSizedTopLeft.png
    • AutoSuggestBox_Icons.png
    • BadgeNotificationTests.png-dark
    • Battery.png-dark
    • BezierSegment.png-dark
    • Border_BorderThickness.png-dark
    • Border_BorderThickness.png
    • Border_Simple_No_Background.png-dark
    • Border_Simple_No_Background.png
    • ButtonWithClippingAndOffset.png-dark
    • ClosedFigure.png-dark
    • ContentControl_NoTemplateNoContent.png
    • ContentControl_SetNull.png-dark
    • DoubleAnimation_BeginTime.png

  • skia-linux-screenshots: 1644 changed over 2216

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AndroidWindowInsets.png
    • AnimatedIconPage.png
    • AppBarButtonWithIconTest.png-dark
    • AppBarToggleButtonTest.png-dark
    • ApplicationViewSizing.png
    • AppWindowClosing.png-dark
    • AppWindowPresenters.png-dark
    • Arrange_Performance01.png-dark
    • Arrange_Performance01.png
    • AutoBorderStretchwithtopmargin.png-dark
    • AutoSuggestBox_BitmapIcon.png-dark
    • BasicAutoSuggestBox.png
    • BasicEnability.png-dark
    • BezierSegment.png
    • BindableDrawerLayout_ChangePane.png-dark
    • BorderRightwithmargins.png
    • BorderTopwithmargins.png-dark
    • Border_AntiAlias.png
    • Border_CornerRadius_Clipping.png-dark
    • Border_Simple_with_Uniform_Thickness.png-dark

  • skia-windows-screenshots: 1502 changed over 2216

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AppBarButtonWithIconTest.png-dark
    • AppBarToggleButtonTest.png-dark
    • ApplicationViewMode.png-dark
    • AppWindowClosing.png-dark
    • AppXamlDefinedResources.png-dark
    • Attributed_text_FontSize_Changing.png-dark
    • AutoSizedPathCentered.png-dark
    • AutoSuggestBox_Reason.png-dark
    • AutoSuggestBox_Reason.png
    • BasicThemeResources.png-dark
    • BorderCenteredwithmargins.png-dark
    • BorderVersusPanelClipping.png-dark
    • Border_CornerRadius.png
    • Border_LinearGradientBrush.png-dark
    • Border_With_ScaleTransform.png
    • Border_With_TranslateTransform.png-dark
    • Border_With_TranslateTransform.png
    • BreadcrumbBarPage.png-dark
    • CenteredGridinGridwiththreefixedsizechildren.png-dark
    • CenteredGridinGridwiththreefixedsizechildren.png

  • wasm: 172 changed over 1043

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • GenericApp.Views.Content.UITests.ImageBrushTestControl.ImageBrush_UniformToFill
    • MUXControlsTestApp.DropDownButtonPage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_ItemTemplateSelector_And_ItemContainerStyleSelector
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Last_Item_Large
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ExpanderTests.ExpanderColorValidationPage
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ExpanderTests.Expander_ScrollView
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ExpanderTests.WinUIExpanderPage
    • UITests.Shared.Windows_UI_Input.GestureRecognizerTests.TransformationsTests
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_SelectedIndex
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_VisibleBounds
    • UITests.Windows_UI_Xaml.FocusTests.Focus_FocusVisual_Properties
    • UITests.Windows_UI_Xaml.FocusTests.Focus_VisualStates
    • UITests.Windows_UI_Xaml.FrameworkElementTests.DynamicBackgroundSizing
    • UITests.Windows_UI_Xaml_Controls.CalendarView.CalendarView_Theming
    • UITests.Windows_UI_Xaml_Controls.ImageTests.SvgImageSource_MultiLoad
    • UITests.Windows_UI_Xaml_Media.FontTests.DynamicFont
    • UITests.Windows_UI_Xaml_Media.GradientBrushTests.GradientsPage
    • MUXControlsTestApp.InfoBarPage
    • MUXControlsTestApp.SwipeControlPage2
    • MUXControlsTestApp.NavigationViewTopNavPage

  • wasm-automated-net8.0-UWP-Default-automated: 52 changed over 1945

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ComboBox_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Description_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Description
    • CommandBar_BackGesture_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_BackGesture
    • CommandBar_CommandBar_BackButtonImage_UITests_Windows_UI_Xaml_Controls_CommandBar_BackButtonImage_CommandBar_Frame
    • Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
    • CommandBar_CommandBar_CustomContent_UITests_Windows_UI_Xaml_Controls_CommandBar_CustomContent_CommandBar_Frame
    • CommandBar_CommandBar_LongTitle_Navigation_UITests_Windows_UI_Xaml_Controls_CommandBar_LongTitle_CommandBar_Frame
    • Focus_GetFocus_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • Default_StrokeThickness_MyPolygon
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
    • ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
    • ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_VisibleBounds_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_VisibleBounds
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Default_StrokeThickness_MyRect
    • Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_VisualStates_UITests_Windows_UI_Xaml_FocusTests_Focus_VisualStates
    • Focus_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection

  • wasm-automated-net8.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net8.0-UWP-RuntimeTests-1: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

  • wasm-automated-net8.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net8.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-2: 0 changed over 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morning4coffe-dev morning4coffe-dev morning4coffe-dev approved these changes

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinZikmund @unodevops @morning4coffe-dev @nventive-devops @jeromelaban