Vite 6 PWA build doesn't seem to resolve the correct file #19087
Labels
Comments
|
I need to add integration: {
configureCustomSWViteBuild: inlineConfig => {
inlineConfig.resolve ??= {}
inlineConfig.resolve.conditions = ['browser', 'module']
},
}, |
Thank you, that solved that problem for me. Didn't realise that this was needed. I have another module, This package is slightly different, in that it has the I'm not sure if this is a bug in the package itself, or if this should also just work? Log: |
|
try using: integration: {
configureCustomSWViteBuild: inlineConfig => {
inlineConfig.resolve ??= {}
inlineConfig.resolve.alias ??= {}
inlineConfig.resolve.alias['pino'] = './node_modules/pino/browser.js'
inlineConfig.resolve.conditions = ['browser', 'module']
},
}, |
Yep, I'm aware I can manually force it to use the file. Should this not work out of the box? |
|
The custom sw build done via Vite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I've tried to upgrade from v5 to v6, but for some reason, the PWA build seems to not quite do what it did before.
This is the output for v6 in the repro repository
For v5:
From what I can tell, vite seems to be picking the node files instead for the browser files, despite the
package.jsonforbroadcast-channelhaving the following. The errors in the console I believe are related due to trying to use the incompatible node files instead of the browser version.Reproduction
https://github.com/jacquesg/sw-repro
Steps to reproduce
pnpm i && pnpm build && pnpm previewOpen
http://localhost:4173The error console should show something like the following:
System Info
System: OS: macOS 15.2 CPU: (14) arm64 Apple M3 Max Memory: 2.55 GB / 36.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 22.8.0 - ~/.nvm/versions/node/v22.8.0/bin/node Yarn: 1.22.22 - /opt/homebrew/bin/yarn npm: 10.8.2 - ~/.nvm/versions/node/v22.8.0/bin/npm pnpm: 9.12.2 - ~/.nvm/versions/node/v22.8.0/bin/pnpm Browsers: Brave Browser: 131.1.73.104 Chrome: 131.0.6778.205 Safari: 18.2 npmPackages: @vitejs/plugin-react: ^4.2.1 => 4.3.4 @vitejs/plugin-react-swc: ^3.7.2 => 3.7.2 vite: ^6.0.6 => 6.0.6Used Package Manager
pnpm
Logs
No response
Validations
The text was updated successfully, but these errors were encountered: